You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jonathan Keane (Jira)" <ji...@apache.org> on 2022/03/26 00:29:00 UTC

[jira] [Commented] (ARROW-16034) [R] should bindings for grepl etc emit warnings matching those in base R functions

    [ https://issues.apache.org/jira/browse/ARROW-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512645#comment-17512645 ] 

Jonathan Keane commented on ARROW-16034:
----------------------------------------

This is definitely nice to give folks a heads up that one of the arguments is being ignored. Looking at the implementation for {{grepl}}, it wouldn't take much overhead at all to add a warning when those two arguments are given. I would be in favor of doing this to be extra clear and helpful. I'm curious if [~icook] has any reason this didn't or wouldn't work form the original implementation?

> [R] should bindings for grepl etc emit warnings matching those in base R functions
> ----------------------------------------------------------------------------------
>
>                 Key: ARROW-16034
>                 URL: https://issues.apache.org/jira/browse/ARROW-16034
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>    Affects Versions: 7.0.0
>            Reporter: Andy Teucher
>            Priority: Minor
>
> {{{}grepl{}}}, {{{}sub{}}}, and {{gsub}} (and perhaps others) in base R emit a warning when {{ignore.case = TRUE}} and {{{}fixed = TRUE{}}}. As raised in the [PR]([https://github.com/apache/arrow/pull/12711]) for this [issue](https://issues.apache.org/jira/browse/ARROW-16007), wondering if this should be mimicked in the arrow bindings as well? [~jonkeane] requested I open this here for discussion.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)