You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/05/24 18:30:31 UTC

[Bug 6340] [review] Impossible to find user home directory of VPOPMAIL alias

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6340

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |kmcgrail@pccc.com
         Resolution|                            |INVALID

--- Comment #18 from Kevin A. McGrail <km...@pccc.com> 2011-05-24 16:30:31 UTC ---
(In reply to comment #17)
> One of patch is wrong. Please correct:
> 
> -      if ($vpopusername_tainted =~ /->  &?(.+)$/) {
> +      if ($vpopusername_tainted =~ /-> &?(.+)$/) {
> 
> Here's one more space. It's possible fix this in 3.3.2?
> Thanks.

Best I can tell, this is in 3.3.2rc1 in spamd.raw and there was no reason to
reopen this unless you meant to have two spaces and the patch above is
reversed.

      if ($vpopusername_tainted =~ /-> &?(.+)$/) {
        $vpopusername = untaint_var($1);
        if ($vpopusername =~ s{^(/.+)/Maildir/$}{$1}) {
          # this is the path to a real mailbox
          $userdir = $vpopusername;

Did you mean you WANT it to be 

+      if ($vpopusername_tainted =~ /-> &?(.+)$/) {
-      if ($vpopusername_tainted =~ /->  &?(.+)$/) {

regards,
KAM

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.