[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #694: [DON'T MERGE][#691] test :fix flaky test CoordinatorMetricsTest#testCoordinatorMetrics

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on PR #694:
URL: https://github.com/apache/incubator-uniffle/pull/694#issuecomment-1461117815

   > I tried to find out why `testCoordinatorMetrics` in `CoordinatorMetricsTest` collected `app_num` in `QuotaManagerTest # testCheckQuotaMetrics`, but there are not many clues. At present, the simplest way is to filter out `app_num` in the indicators, do you have any good suggestions ? @jerqi @advancedxy @xianjingfeng 
   > 
   > The result as follow:
   > ```
   > Test metrics => [
   > {"name":"running_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_quota_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_load_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"remote_storage_in_used_path1","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_candidates_denied_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_app_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"app_num","labelNames":["user_name"],"labelValues":["user3"],"value":0.0,"timestampMs":null},
   > {"name":"app_num","labelNames":["user_name"],"labelValues":["user4"],"value":0.0,"timestampMs":null},
   > {"name":"unhealthy_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"total_access_request","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null},
   > {"name":"exclude_server_num","labelNames":[],"labelValues":[],"value":0.0,"timestampMs":null}]
   > ```
   
   I think we can remove this test case. it doesn't make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org