You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/08/02 13:57:29 UTC
[GitHub] [openwhisk-runtime-nodejs] upgle opened a new pull request, #221: Bumping to gradle 6
upgle opened a new pull request, #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221
## Description
Use the same version of gradle as openwhisk core project.
related to https://github.com/apache/openwhisk/pull/5276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] upgle commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936408487
##########
core/nodejsActionBase/src/service.js:
##########
@@ -143,7 +143,7 @@ function NodeActionService(config) {
setStatus(Status.ready);
}
if (typeof result !== 'object') {
- return errorMessage(502, 'The action did not return a dictionary.');
+ return errorMessage(502, 'The action did not return a dictionary or array.');
Review Comment:
It's affected by https://github.com/apache/openwhisk/pull/5290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] ningyougang merged pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
ningyougang merged PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] upgle commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936174947
##########
tests/build.gradle:
##########
@@ -34,9 +34,11 @@ tasks.withType(Test) {
}
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+ implementation "junit:junit:4.11"
Review Comment:
A parent project (openwhisk core) that uses `implementation` instead of `compile` no longer provides dependencies to child projects. It needs to re-add the required dependencies for testing with `implementation` in sub project.
related documents:
- https://docs.gradle.org/current/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations
- https://docs.gradle.org/current/userguide/declaring_dependencies.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] ningyougang commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936171331
##########
tests/build.gradle:
##########
@@ -34,9 +34,11 @@ tasks.withType(Test) {
}
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+ implementation "junit:junit:4.11"
Review Comment:
Ah, i see, this is a option, i will check it in go runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] ningyougang commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936171331
##########
tests/build.gradle:
##########
@@ -34,9 +34,11 @@ tasks.withType(Test) {
}
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+ implementation "junit:junit:4.11"
Review Comment:
Ah, i see, this is a option, i will check it in go runtime, seems still exist in my local after added `implementation "junit:junit:4.11"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] ningyougang commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936093488
##########
tests/build.gradle:
##########
@@ -34,9 +34,9 @@ tasks.withType(Test) {
}
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+ implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+ implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
+ implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
Review Comment:
I applied the same changes for openwhisk-runtime-go, tested in local, the junit problem also existed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] upgle commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
upgle commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936460388
##########
core/nodejsActionBase/src/service.js:
##########
@@ -143,7 +143,7 @@ function NodeActionService(config) {
setStatus(Status.ready);
}
if (typeof result !== 'object') {
- return errorMessage(502, 'The action did not return a dictionary.');
+ return errorMessage(502, 'The action did not return a dictionary or array.');
Review Comment:
I opened new PR https://github.com/apache/openwhisk/pull/5306 to fix compatibility issue.
I'll revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-nodejs] ningyougang commented on a diff in pull request #221: Bumping to gradle 6
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #221:
URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/221#discussion_r936093488
##########
tests/build.gradle:
##########
@@ -34,9 +34,9 @@ tasks.withType(Test) {
}
dependencies {
- compile "org.scala-lang:scala-library:${gradle.scala.version}"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
- compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
+ implementation "org.scala-lang:scala-library:${gradle.scala.version}"
+ implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
+ implementation "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
Review Comment:
I applied the same changes for openwhisk-runtime-go, tested in local, the junit problem also existed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org