You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/10/19 16:02:01 UTC

Re: [PR] [SPARK-45368]Remove scala2.12 compatibility logic for DoubleType, FloatType, Decimal [spark]

laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1771289209

   As a beginner, I read some of the code here，I am amazed by the type design and submitted a PR.
   Double and Float have removed the traits and directly inherited the traits of scala 2.13.
   The decimal code is quite extensive, and I don't have a deep understanding，It seems to me that just need to remove comment，maybe it's incorrect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org