You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/29 21:33:16 UTC

[GitHub] [calcite] qizhou92 opened a new pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

qizhou92 opened a new pull request #2048:
URL: https://github.com/apache/calcite/pull/2048


   Add dependency for z3, add two simple tests to test if native library work.
   I am new to this process, and I am not quite sure how much code I should push in commit to reviewing.  
   Welcome any feedback or propose, given a relatively large number of codes that I need to implement this function. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] qizhou92 closed pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

Posted by GitBox <gi...@apache.org>.
qizhou92 closed pull request #2048:
URL: https://github.com/apache/calcite/pull/2048


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] qizhou92 commented on pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

Posted by GitBox <gi...@apache.org>.
qizhou92 commented on pull request #2048:
URL: https://github.com/apache/calcite/pull/2048#issuecomment-719083818


   I choose to close this pull request, given the commit tree becomes too complicated. I create another pull request with a much clean commit tree. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] qizhou92 commented on pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

Posted by GitBox <gi...@apache.org>.
qizhou92 commented on pull request #2048:
URL: https://github.com/apache/calcite/pull/2048#issuecomment-719032250


   I am sorry, I make the commit tree unnecessarily complicated, because of some of my wrongdoings. Any suggestion for a clean up the commit tree?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] danny0405 commented on pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2048:
URL: https://github.com/apache/calcite/pull/2048#issuecomment-718319649


   Thanks @qizhou92 for the contribution, you may need to rebase the code again, there are many commits of the master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org