You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/22 16:37:08 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1099: sched/task: add use stack support for kernel thread

patacongo commented on a change in pull request #1099:
URL: https://github.com/apache/incubator-nuttx/pull/1099#discussion_r429345837



##########
File path: sched/task/task_create.c
##########
@@ -286,6 +297,36 @@ int task_create(FAR const char *name, int priority,
 int kthread_create(FAR const char *name, int priority,
                    int stack_size, main_t entry, FAR char * const argv[])
 {
-  return nxthread_create(name, TCB_FLAG_TTYPE_KERNEL, priority, stack_size,
-                         entry, argv);
+  return nxthread_create(name, TCB_FLAG_TTYPE_KERNEL, priority, NULL,
+                         stack_size, entry, argv);
+}
+
+/****************************************************************************
+ * Name: kthread_create2

Review comment:
       I really dislike this naming.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org