You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/05 13:13:32 UTC

[GitHub] [dubbo-go] AlexStocks opened a new issue #1562: Fix:

AlexStocks opened a new issue #1562:
URL: https://github.com/apache/dubbo-go/issues/1562


   <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
   
   -->
   
   **What happened**:
   
   the ut of the following source files are remarked.
   
   ```
       protocol/dubbo/dubbo_protocol_test.go
       registry/etcdv3/service_discovery_test.go
       registry/zookeeper/service_discovery_test.go
       registry/nacos/service_discovery_test.go
       registry/file/service_discovery_test.go
   ```
   
   **What you expected to happen**:
   
   1 delete out of date ut files;
   2 fix the left source file's wrong uts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1562: Fix: improve the unit coverage ratio

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1562:
URL: https://github.com/apache/dubbo-go/issues/1562#issuecomment-961909518


   registry/file/service_discovery_test.go 可以直接删掉
   service-discovery:file 相关的可以全部在3.0 删掉。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1562: Fix: improve the unit coverage ratio

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1562:
URL: https://github.com/apache/dubbo-go/issues/1562#issuecomment-961909518






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] beiping0 commented on issue #1562: Fix: improve the unit coverage ratio

Posted by GitBox <gi...@apache.org>.
beiping0 commented on issue #1562:
URL: https://github.com/apache/dubbo-go/issues/1562#issuecomment-1070481345


   github:m18827119865_2@163.com


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1562: Fix: improve the unit coverage ratio

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on issue #1562:
URL: https://github.com/apache/dubbo-go/issues/1562#issuecomment-961909977


   @Mulavar @justxuewei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org