You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/04 07:09:08 UTC

[GitHub] [apisix] tzssangglass opened a new issue #2623: bug: the latest version of the skywalking plugin always outputs error log

tzssangglass opened a new issue #2623:
URL: https://github.com/apache/apisix/issues/2623


   ### Issue description
   I pulled the latest code and found a persistent error level output in the logs/error.log
   
   ```
   2020/11/04 14:54:50 [error] 20481#20481: *28563 [lua] client.lua:92: reportServiceInstance(): Instance report fails, connection refused, context: ngx.timer
   2020/11/04 14:54:53 [error] 20481#20481: *28739 [lua] client.lua:92: reportServiceInstance(): Instance report fails, connection refused, context: ngx.timer
   2020/11/04 14:54:56 [error] 20481#20481: *28918 [lua] client.lua:92: reportServiceInstance(): Instance report fails, connection refused, context: ngx.timer
   ```
   
   I found this to be the code for the skywalking module, even though I did not configure the `skywalking` plugin
   
   The function call stack is as follows:
   `skywalking.lua#init()` --> `client.lua#startBackendTimer()` --> `client.lua#reportServiceInstance()`
   
   It may be necessary to verify that the user has configured the `skywalking` plugin during the `init` phase.
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): lastest
   * OS: centos7
   
   ### Minimal test code / Steps to reproduce the issue
   just start apisix, then watch the error.log
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   
   
   ### What's the expected result?
   Do not export any logs from the skywalking module without the skywalking plugin enabled.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721627648


   > @membphis
   > Maybe we can make skywalking disable by default so the background timer won't be a problem.
   
   I also suffer from this problem in my dev environment, which may distrubs the result of unit test (`no_error_log` or the analogues ).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721618122


   @membphis 
   Maybe we can make skywalking disable by default so the background timer won't be a problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721634780


   > > “just start apisix, then watch the error.log” ——Can you tell me how long need to wait? This is very helpful for design test cases.
   > 
   > 3 seconds.
   > 
   > https://github.com/apache/skywalking-nginx-lua/blob/cda47ae0a507ab86a378a298325c3c94d9a773c2/lib/skywalking/client.lua#L28-L48
   
   thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721609753


   “just start apisix, then watch the error.log” ——Can you tell me how long need to wait? This is very helpful for design test cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721736056


   > Maybe we can make skywalking disable by default so the background timer won't be a problem.
   
   agree ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tzssangglass commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721626039


   > “just start apisix, then watch the error.log” ——Can you tell me how long need to wait? This is very helpful for design test cases.
   
   3 seconds. 
   
   https://github.com/apache/skywalking-nginx-lua/blob/cda47ae0a507ab86a378a298325c3c94d9a773c2/lib/skywalking/client.lua#L28-L48


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] moonming closed issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
moonming closed issue #2623:
URL: https://github.com/apache/apisix/issues/2623


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2623: bug: the latest version of the skywalking plugin always outputs error log

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2623:
URL: https://github.com/apache/apisix/issues/2623#issuecomment-721610732


   Current solution:
   You can copy the plugin you need from `config-default.yaml` to `config.yaml` without  skywalking, like this:
   ```yaml
   
   plugins:
     ... # plugin you need
     # without - skywalking
   
   ```
   
   So the skywalking background timer will not be triggered anymore.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org