[GitHub] [hadoop-ozone] GlenGeng commented on a change in pull request #1145: HDDS-3895. Implement container related operations in ContainerManagerImpl

[GitBox <gi...@apache.org>]

GlenGeng commented on a change in pull request #1145:
URL: https://github.com/apache/hadoop-ozone/pull/1145#discussion_r473664946



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java
##########
@@ -291,23 +328,14 @@ ContainerInfo getMatchingContainer(final long size, String owner,
     throw new UnsupportedOperationException("Not yet implemented!");
   }
 
-
   NavigableSet<ContainerID> getMatchingContainerIDs(final String owner,
       final ReplicationType type, final ReplicationFactor factor,
       final LifeCycleState state) {
     throw new UnsupportedOperationException("Not yet implemented!");
   }
 
-  void removeContainerReplica(final ContainerID containerID,
-                              final ContainerReplica replica)
-      throws ContainerNotFoundException, ContainerReplicaNotFoundException {
-    throw new UnsupportedOperationException("Not yet implemented!");
-  }
-
-
-  void removeContainer(final ContainerID containerID)
-      throws ContainerNotFoundException {
-    throw new UnsupportedOperationException("Not yet implemented!");
+  public void removeContainer(final HddsProtos.ContainerID id) {
+    containers.removeContainer(ContainerID.getFromProtobuf(id));

Review comment:
       Show we update `containerStore` as well ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org