You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "Kevinwochan (via GitHub)" <gi...@apache.org> on 2025/04/25 14:55:46 UTC
[PR] Logging DTD validation error instead of throwing an exception [netbeans]
Kevinwochan opened a new pull request, #8457:
URL: https://github.com/apache/netbeans/pull/8457
In corporate networks with limited internet access, Netbeans is unable to build modules due to the internet dependency on remote DTDs.
Currently, when `ant nbm` is executed `makeNBM.validateAgainstAUDTDs()` throws an SSL exception when attempting to download the AutoUpdate DTDs from http://www.netbeans.org/dtds/ (which redirects to https://netbeans.apache.org/dtds/).
This can occur when the corporate JRE used does not have netbeans.apache.org certificate or when internet access is not available.
This PR proposes a solution with minimal code change: logging a DTD validation error at build time rather than throwing an uncaught exception which prevents Netbeans from continuing with the build.
---
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [x] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [x] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [x] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Logging DTD validation error instead of throwing an exception [netbeans]
Posted by "Kevinwochan (via GitHub)" <gi...@apache.org>.
Kevinwochan closed pull request #8457: Logging DTD validation error instead of throwing an exception
URL: https://github.com/apache/netbeans/pull/8457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Logging DTD validation error instead of throwing an exception [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8457:
URL: https://github.com/apache/netbeans/pull/8457#issuecomment-2833436623
Could please describe your build setup? I mean, how you build what? There is code in the validator that redirects the DTD resolving to bundled DTDs:
https://github.com/apache/netbeans/blob/92eb77dc9445a5ae3f5be1d17276818e472659b2/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java#L1103-L1118
I validated with a debugger, that the local resolver is hit. This raises the question: Why is that not the case for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Logging DTD validation error instead of throwing an exception [netbeans]
Posted by "Kevinwochan (via GitHub)" <gi...@apache.org>.
Kevinwochan commented on PR #8457:
URL: https://github.com/apache/netbeans/pull/8457#issuecomment-2833438165
I'll create a repo example replicating the problem, it did seem like line 1108 is supposed to use a local resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists