You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/01 05:26:56 UTC
[GitHub] [apisix] navendu-pottekkat opened a new pull request #6775: docs: update "Transformation" Plugins
navendu-pottekkat opened a new pull request #6775:
URL: https://github.com/apache/apisix/pull/6775
Signed-off-by: Navendu Pottekkat <na...@gmail.com>
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Updates the documentation of the "Transformation" Plugins.
Child PR of #6734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on a change in pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on a change in pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#discussion_r841006435
##########
File path: docs/en/latest/plugins/fault-injection.md
##########
@@ -1,5 +1,11 @@
---
title: fault-injection
+keywords:
+ - APISIX
+ - Plugin
+ - Fault Injection
+ - fault-injection
+description: This document contains information about the Apache APISIX fault-injection Plugin.
Review comment:
Maybe we need to make some changes in the configuration: https://github.com/apache/skywalking-eyes#configurations
I could not find any but maybe that could be the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#discussion_r841028406
##########
File path: docs/en/latest/plugins/fault-injection.md
##########
@@ -1,5 +1,11 @@
---
title: fault-injection
+keywords:
+ - APISIX
+ - Plugin
+ - Fault Injection
+ - fault-injection
+description: This document contains information about the Apache APISIX fault-injection Plugin.
Review comment:
> The other attributes were working when I tested. i.e, Keywords and descriptions were showing properly for the page.
Hi, Navendu, I'm not sure if it's because CI will skip `title` only.
need @spacewander's help to check why CI will fail 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#issuecomment-1085816572
@leslie-tsang It does not explain why the license checker fails. I haven't removed it. The only change I made is that I added YAML front matter to the one already existing. Any clue why this fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#issuecomment-1086474168
> @leslie-tsang It does not explain why the license checker fails. I haven't removed it. The only change I made is that I added YAML front matter to the one already existing. Any clue why this fails?
I'll check it out later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#issuecomment-1085498161
> LGTM. Anyone could help on License checker failure? @juzhiyuan @leslie-tsang
ERROR the following files don't have a valid license header:
* docs/en/latest/plugins/fault-injection.md
* docs/en/latest/plugins/grpc-transcode.md
* docs/en/latest/plugins/grpc-web.md
* docs/en/latest/plugins/mocking.md
* docs/en/latest/plugins/proxy-rewrite.md
* docs/en/latest/plugins/response-rewrite.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#issuecomment-1085442604
@juzhiyuan @yzeng25 @avinal @hf400159 Could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on a change in pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on a change in pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#discussion_r841006250
##########
File path: docs/en/latest/plugins/fault-injection.md
##########
@@ -1,5 +1,11 @@
---
title: fault-injection
+keywords:
+ - APISIX
+ - Plugin
+ - Fault Injection
+ - fault-injection
+description: This document contains information about the Apache APISIX fault-injection Plugin.
Review comment:
The other attributes were working when I tested. i.e, Keywords and descriptions were showing properly for the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] yzeng25 commented on pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
yzeng25 commented on pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#issuecomment-1085461047
LGTM. Anyone could help on License checker failure? @juzhiyuan @leslie-tsang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#discussion_r841001769
##########
File path: docs/en/latest/plugins/fault-injection.md
##########
@@ -1,5 +1,11 @@
---
title: fault-injection
+keywords:
+ - APISIX
+ - Plugin
+ - Fault Injection
+ - fault-injection
+description: This document contains information about the Apache APISIX fault-injection Plugin.
Review comment:
Maybe License Checker failed due to markdown meta changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #6775: docs: update "Transformation" Plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #6775:
URL: https://github.com/apache/apisix/pull/6775#discussion_r841001811
##########
File path: docs/en/latest/plugins/fault-injection.md
##########
@@ -1,5 +1,11 @@
---
title: fault-injection
+keywords:
+ - APISIX
+ - Plugin
+ - Fault Injection
+ - fault-injection
+description: This document contains information about the Apache APISIX fault-injection Plugin.
Review comment:
Only supports the `title` attribute? I'm not sure, need to verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org