You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/03/12 08:00:31 UTC

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations 

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17177


Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................

IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Webpage of catalogd operations doesn't sum up requests correctly.
Instead, the current meaning is summing by tables. As the column name
is "Number of requests", we should sum up by requests.

Tests:
 - Manually run test_concurrent_inserts and verify the number is
   correct.

Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
---
M be/src/catalog/catalog-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/17177/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8347/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Mar 2021 08:20:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 04:15:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 1: Code-Review+2

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 20:59:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 1: Code-Review+1

Hi Quanlong, nice catch. LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Mar 2021 11:04:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7035/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17177 )

Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations
......................................................................

IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

Webpage of catalogd operations doesn't sum up requests correctly.
Instead, the current meaning is summing by tables. As the column name
is "Number of requests", we should sum up by requests.

Tests:
 - Manually run test_concurrent_inserts and verify the number is
   correct.

Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Reviewed-on: http://gerrit.cloudera.org:8080/17177
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c5361d981832d6f28db5f203a2c2538fe8ebb5e
Gerrit-Change-Number: 17177
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>