You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ace.apache.org by Marcel Offermans <ma...@luminis.nl> on 2011/02/28 23:40:11 UTC
Re: svn commit: r1075548 - in /incubator/ace/trunk: ace-discovery-property/pom.xml ace-identification-property/pom.xml ace-obr-storage/pom.xml ace-repository-impl/pom.xml ace-webui-vaadin/osgi.bnd
On Feb 28, 2011, at 22:41 , <jb...@apache.org> wrote:
> Author: jbonofre
> Date: Mon Feb 28 21:41:41 2011
> New Revision: 1075548
> Modified: incubator/ace/trunk/ace-discovery-property/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-discovery-property/pom.xml?rev=1075548&r1=1075547&r2=1075548&view=diff
> ==============================================================================
> --- incubator/ace/trunk/ace-discovery-property/pom.xml (original)
> +++ incubator/ace/trunk/ace-discovery-property/pom.xml Mon Feb 28 21:41:41 2011
> @@ -40,7 +40,8 @@
> *
> </import.package>
> <private.package>
> - org.apache.ace.discovery.property
> + org.apache.ace.discovery.property,
> + org.apache.ace.discovery.property.constants
> </private.package>
> <bundle.activator>org.apache.ace.discovery.property.Activator</bundle.activator>
> </properties>
Why are you adding the .constants package? It only contains constants that are applied by the Java compiler. They are not needed at all at runtime, which is why we did not include them in the first place.
Also, I regret to have to say the the build is still broken. That means I basically could not take a look at the problematic integration test that kept hanging. I would really appreciate it if you would fix the build on the next commit, or roll everything back to a compiling state and prepare an update that works completely.
Greetings, Marcel
Re: svn commit: r1075548 - in /incubator/ace/trunk: ace-discovery-property/pom.xml
ace-identification-property/pom.xml ace-obr-storage/pom.xml ace-repository-impl/pom.xml
ace-webui-vaadin/osgi.bnd
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Marcel,
as you can see, constants are defined in the private package statement,
so not exposed to others bundles.
If you don't define it at least in the private package, felix
maven-bundle-plugin doesn't include it in the bundle jar.
As this package is used in the integration tests, it should be embedded
in the generated bundle jar.
For the build, I'm cleaning my local maven repo and fix it.
Regards
JB
On 02/28/2011 11:40 PM, Marcel Offermans wrote:
> On Feb 28, 2011, at 22:41 ,<jb...@apache.org> wrote:
>
>> Author: jbonofre
>> Date: Mon Feb 28 21:41:41 2011
>> New Revision: 1075548
>
>> Modified: incubator/ace/trunk/ace-discovery-property/pom.xml
>> URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-discovery-property/pom.xml?rev=1075548&r1=1075547&r2=1075548&view=diff
>> ==============================================================================
>> --- incubator/ace/trunk/ace-discovery-property/pom.xml (original)
>> +++ incubator/ace/trunk/ace-discovery-property/pom.xml Mon Feb 28 21:41:41 2011
>> @@ -40,7 +40,8 @@
>> *
>> </import.package>
>> <private.package>
>> - org.apache.ace.discovery.property
>> + org.apache.ace.discovery.property,
>> + org.apache.ace.discovery.property.constants
>> </private.package>
>> <bundle.activator>org.apache.ace.discovery.property.Activator</bundle.activator>
>> </properties>
>
> Why are you adding the .constants package? It only contains constants that are applied by the Java compiler. They are not needed at all at runtime, which is why we did not include them in the first place.
>
> Also, I regret to have to say the the build is still broken. That means I basically could not take a look at the problematic integration test that kept hanging. I would really appreciate it if you would fix the build on the next commit, or roll everything back to a compiling state and prepare an update that works completely.
>
> Greetings, Marcel
>
Re: svn commit: r1075548 - in /incubator/ace/trunk: ace-discovery-property/pom.xml
ace-identification-property/pom.xml ace-obr-storage/pom.xml ace-repository-impl/pom.xml
ace-webui-vaadin/osgi.bnd
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Sorry, I forgot the revision 1075685.
On 02/28/2011 11:40 PM, Marcel Offermans wrote:
> On Feb 28, 2011, at 22:41 ,<jb...@apache.org> wrote:
>
>> Author: jbonofre
>> Date: Mon Feb 28 21:41:41 2011
>> New Revision: 1075548
>
>> Modified: incubator/ace/trunk/ace-discovery-property/pom.xml
>> URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-discovery-property/pom.xml?rev=1075548&r1=1075547&r2=1075548&view=diff
>> ==============================================================================
>> --- incubator/ace/trunk/ace-discovery-property/pom.xml (original)
>> +++ incubator/ace/trunk/ace-discovery-property/pom.xml Mon Feb 28 21:41:41 2011
>> @@ -40,7 +40,8 @@
>> *
>> </import.package>
>> <private.package>
>> - org.apache.ace.discovery.property
>> + org.apache.ace.discovery.property,
>> + org.apache.ace.discovery.property.constants
>> </private.package>
>> <bundle.activator>org.apache.ace.discovery.property.Activator</bundle.activator>
>> </properties>
>
> Why are you adding the .constants package? It only contains constants that are applied by the Java compiler. They are not needed at all at runtime, which is why we did not include them in the first place.
>
> Also, I regret to have to say the the build is still broken. That means I basically could not take a look at the problematic integration test that kept hanging. I would really appreciate it if you would fix the build on the next commit, or roll everything back to a compiling state and prepare an update that works completely.
>
> Greetings, Marcel
>
Re: svn commit: r1075548 - in /incubator/ace/trunk: ace-discovery-property/pom.xml
ace-identification-property/pom.xml ace-obr-storage/pom.xml ace-repository-impl/pom.xml
ace-webui-vaadin/osgi.bnd
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
The build is now fixed (revision ):
[~/workspace/ace]$ rm -r ~/.m2/repository/*
[~/workspace/ace]$ mvn clean install -Dmaven.test.skip=true
[...]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache ACE :: POM ................................. SUCCESS
[2:21.975s]
[INFO] Apache ACE :: Deployment :: Provider :: API ....... SUCCESS [13.932s]
[INFO] Apache ACE :: Util ................................ SUCCESS [7.923s]
[INFO] Apache ACE :: Range :: API ........................ SUCCESS [1.702s]
[INFO] Apache ACE :: Repository :: API ................... SUCCESS [1.432s]
[INFO] Apache ACE :: Repository :: Extensions ............ SUCCESS [13.595s]
[INFO] Apache ACE :: Repository :: Impl .................. SUCCESS [8.879s]
[INFO] Apache ACE :: Repository :: Servlet ............... SUCCESS [1.576s]
[INFO] Apache ACE :: Discovery :: API .................... SUCCESS [0.915s]
[INFO] Apache ACE :: Scheduler :: API .................... SUCCESS [1.114s]
[INFO] Apache ACE :: Repository :: Task .................. SUCCESS [1.428s]
[INFO] Apache ACE :: ConsoleLogger ....................... SUCCESS [1.216s]
[INFO] Apache ACE :: Log ................................. SUCCESS [1.161s]
[INFO] Apache ACE :: Discovery :: Property Based ......... SUCCESS [1.784s]
[INFO] Apache ACE :: Discovery :: UPNP ................... SUCCESS [5.191s]
[INFO] Apache ACE :: Identification :: API ............... SUCCESS [1.079s]
[INFO] Apache ACE :: Identification :: Property Based .... SUCCESS [1.270s]
[INFO] Apache ACE :: Identification :: Ifconfig .......... SUCCESS [1.114s]
[INFO] Apache ACE :: Scheduler ........................... SUCCESS [1.356s]
[INFO] Apache ACE :: Client :: Repository :: API ......... SUCCESS [1.838s]
[INFO] Apache ACE :: Server :: Log :: Store .............. SUCCESS [1.708s]
[INFO] Apache ACE :: Client :: Repository :: Helper :: Bundle SUCCESS
[2.489s]
[INFO] Apache ACE :: Client :: Repository :: Implementation SUCCESS
[13.675s]
[INFO] Apache ACE :: Client :: Repository :: Helper :: Base SUCCESS
[14.075s]
[INFO] Apache ACE :: Client :: Repository :: Helper :: Configuration
SUCCESS [1.442s]
[INFO] Apache ACE :: Client :: Repository :: Helper :: User SUCCESS
[1.336s]
[INFO] Apache ACE :: Client :: Automation ................ SUCCESS [1.301s]
[INFO] Apache ACE :: Deployment :: Streamgenerator ....... SUCCESS [27.249s]
[INFO] Apache ACE :: Deployment :: Servlet ............... SUCCESS [3.965s]
[INFO] Apache ACE :: Deployment :: Provider :: Base (library) SUCCESS
[1.631s]
[INFO] Apache ACE :: Deployment :: Provider :: Filebased . SUCCESS [1.367s]
[INFO] Apache ACE :: Deployment :: Provider :: Repositorybased SUCCESS
[1.619s]
[INFO] Apache ACE :: Deployment :: API ................... SUCCESS [1.267s]
[INFO] Apache ACE :: Deployment :: DeploymentAdmin Based . SUCCESS [1.229s]
[INFO] Apache ACE :: Gateway :: Log :: Store ............. SUCCESS [1.514s]
[INFO] Apache ACE :: Deployment :: Task .................. SUCCESS [1.400s]
[INFO] Apache ACE :: HttpListener ........................ SUCCESS [1.217s]
[INFO] Apache ACE :: Log :: Servlet ...................... SUCCESS [1.345s]
[INFO] Apache ACE :: Log :: Task ......................... SUCCESS [1.377s]
[INFO] Apache ACE :: Log :: Listener ..................... SUCCESS [1.431s]
[INFO] Apache ACE :: OBR :: Metadata ..................... SUCCESS [5.047s]
[INFO] Apache ACE :: OBR :: Storage ...................... SUCCESS [1.375s]
[INFO] Apache ACE :: OBR :: Servlet ...................... SUCCESS [1.258s]
[INFO] Apache ACE :: Configurator :: Server UserAdmin .... SUCCESS [1.186s]
[INFO] Apache ACE :: Resourceprocessor :: UserAdmin ...... SUCCESS [1.438s]
[INFO] Apache ACE :: Configurator :: UserAdmin :: Task ... SUCCESS [1.529s]
[INFO] Apache ACE :: Client :: Repository :: UserAdmin ... SUCCESS [2.154s]
[INFO] Apache ACE :: Server :: Action API ................ SUCCESS [1.933s]
[INFO] Apache ACE :: Server :: Action :: Popup Message ... SUCCESS [1.427s]
[INFO] Apache ACE :: Location :: UPNP Service ............ SUCCESS [1.508s]
[INFO] Apache ACE :: Webconsole :: Plugin ................ SUCCESS [1.130s]
[INFO] Apache ACE :: Configurator ........................ SUCCESS [1.387s]
[INFO] Apache ACE :: Gateway :: Log ...................... SUCCESS [1.307s]
[INFO] Apache ACE :: Web UI .............................. SUCCESS
[5:03.883s]
[INFO] Apache ACE :: Web UI :: Vaadin .................... SUCCESS [18.723s]
[INFO] Apache ACE :: Management Agent .................... SUCCESS [24.864s]
[INFO] Apache ACE :: Launcher ............................ SUCCESS [34.773s]
[INFO] Apache ACE :: Target :: Defaults .................. SUCCESS [0.822s]
[INFO] Apache ACE :: Target :: Dev Gateway ............... SUCCESS [35.304s]
[INFO] Apache ACE :: Target :: Dev Server ................ SUCCESS
[1:11.809s]
[INFO] Apache ACE :: Integration Tests ................... SUCCESS
[1:19.576s]
[INFO] Apache ACE :: Reactor ............................. SUCCESS [0.048s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 16:00.523s
[INFO] Finished at: Tue Mar 01 07:59:34 CET 2011
[INFO] Final Memory: 39M/259M
[INFO]
------------------------------------------------------------------------
We have issues on the integration tests. I'm going to work on it.
I will also remove the "old" GWT web UI (ACE-132).
Regards
JB
On 02/28/2011 11:40 PM, Marcel Offermans wrote:
> On Feb 28, 2011, at 22:41 ,<jb...@apache.org> wrote:
>
>> Author: jbonofre
>> Date: Mon Feb 28 21:41:41 2011
>> New Revision: 1075548
>
>> Modified: incubator/ace/trunk/ace-discovery-property/pom.xml
>> URL: http://svn.apache.org/viewvc/incubator/ace/trunk/ace-discovery-property/pom.xml?rev=1075548&r1=1075547&r2=1075548&view=diff
>> ==============================================================================
>> --- incubator/ace/trunk/ace-discovery-property/pom.xml (original)
>> +++ incubator/ace/trunk/ace-discovery-property/pom.xml Mon Feb 28 21:41:41 2011
>> @@ -40,7 +40,8 @@
>> *
>> </import.package>
>> <private.package>
>> - org.apache.ace.discovery.property
>> + org.apache.ace.discovery.property,
>> + org.apache.ace.discovery.property.constants
>> </private.package>
>> <bundle.activator>org.apache.ace.discovery.property.Activator</bundle.activator>
>> </properties>
>
> Why are you adding the .constants package? It only contains constants that are applied by the Java compiler. They are not needed at all at runtime, which is why we did not include them in the first place.
>
> Also, I regret to have to say the the build is still broken. That means I basically could not take a look at the problematic integration test that kept hanging. I would really appreciate it if you would fix the build on the next commit, or roll everything back to a compiling state and prepare an update that works completely.
>
> Greetings, Marcel
>