You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/30 07:36:28 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #19046: [API] clean up gluon contrib
szha opened a new pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046
## Description ##
clean up gluon contrib
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] add mx.np.random.seed
- [x] remove gluon.contrib.text
- [x] remove mx.contrib.autograd
- [x] promote IntervalSampler, SyncBatchNorm, Concurrent as Concatenate, HybridConcurrent as HybridConcatenate, Identity, DeformableConvolution, ModulatedDeformableConvolution, PixelShuffle1D, PixelShuffle2D, PixelShuffle3D, VariationalDropoutCell, LSTMPCell, Conv1DRNNCell, Conv2DRNNCell, Conv3DRNNCell, Conv1DLSTMCell, Conv2DLSTMCell, Conv3DLSTMCell, Conv1DGRUCell, Conv2DGRUCell, Conv3DGRUCell
- [ ] numpy equivalent tests
## Comments ##
- cc @zhreshold for cv block changes, @sxjscience for convrnn changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-687559723
Do we need to test the RNNCells under mx.np? (We may make another PR for this purpose since it may make the PR be too large)
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Sheng Zha <no...@github.com>
Sent: Friday, September 4, 2020 10:19:00 PM
To: apache/incubator-mxnet <in...@noreply.github.com>
Cc: Xingjian SHI <xs...@connect.ust.hk>; Mention <me...@noreply.github.com>
Subject: Re: [apache/incubator-mxnet] [API] clean up gluon contrib (#19046)
ready for review. rnn cell may need some design change and I intend to submit it separately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-687553008>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHQH3VY6JCKJDGVSCE2HRTSEHC4JANCNFSM4QPO7Y6Q>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-687553008
ready for review. rnn cell may need some design change and I intend to submit it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-683387552
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, edge, windows-gpu, website, centos-cpu, clang, sanity, windows-cpu, unix-cpu, unix-gpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-687560437
rnn cells haven't been refactored to use np yet. will follow that up in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha edited a comment on pull request #19046: [API] clean up gluon contrib
Posted by GitBox <gi...@apache.org>.
szha edited a comment on pull request #19046:
URL: https://github.com/apache/incubator-mxnet/pull/19046#issuecomment-687553008
ready for review. rnn cell may need some refactor and I intend to submit it separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org