[jira] [Created] (TAP5-2705) Fix warning Could not add object with duplicate id 'tapestry.css'

["D Tim Cummings (Jira)" <ji...@apache.org>]

D Tim Cummings created TAP5-2705:
------------------------------------

             Summary: Fix warning Could not add object with duplicate id 'tapestry.css'
                 Key: TAP5-2705
                 URL: https://issues.apache.org/jira/browse/TAP5-2705
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.8.0, 5.7.3, 5.6.4, 5.7.2, 5.7.1, 5.6.3, 5.7.0, 5.6.2, 5.6.1, 5.6.0, 5.5.0
            Reporter: D Tim Cummings
         Attachments: JavaScriptModule.diff

For the last few versions of tapestry, the following warning messages would show in the logs

{{WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry.css'.  The duplicate object has been ignored.}}
{{WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'exception-frame.css'.  The duplicate object has been ignored.}}
{{WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry-console.css'.  The duplicate object has been ignored.}}
{{WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tree.css'.  The duplicate object has been ignored.}}

I think this is because the method addCoreStylesheets in JavaScriptModule is being called multiple times but it should only be called once. This is mainly related to adding bootstrap 4 and font-awesome. I have created a diff which shows what changes are needed so that addCoreStylesheets is only called once. Unfortunately I haven't been able to test it as I haven't worked out yet how to build tapestry from source.

 

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)