You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/01 00:41:01 UTC
Re: Review Request 30643: Optionally specify executor for "mesos
execute".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review89976
-----------------------------------------------------------
Ship it!
Ship It!
src/cli/execute.cpp (line 101)
<https://reviews.apache.org/r/30643/#comment142884>
I think we should remove '/path/to/file' since parsing throws a warning that it's expecting a file:// prefix.
- Timothy Chen
On May 26, 2015, 10:49 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30643/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 10:49 p.m.)
>
>
> Review request for mesos, Timothy Chen and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provided executor will be used to run the task rather than deferring to the slave to determine an executor to use (currently the local included command executor).
>
> This is helpful for testing containers with filesystem isolation as you can fetch an executor into the work directory rather than using the command executor on the host filesystem. You can, of course, still use the command executor, but it will be copied/fetched.
>
> +tnachen - can you please verify I've preserved the override functionality in the command executor? Is that still required?
>
>
> Diffs
> -----
>
> src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17
> src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098
> src/launcher/executor.cpp de6f1b104a765a8e53934154e78872b03695b24c
>
> Diff: https://reviews.apache.org/r/30643/diff/
>
>
> Testing
> -------
>
> make check
>
> manually used 'mesos execute' and specified command executor, both directly as the value and fetching from file:///. Tested enviroment variables too.
>
>
> Thanks,
>
> Ian Downes
>
>