You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by jlahoda <gi...@git.apache.org> on 2017/10/01 20:20:08 UTC
[GitHub] incubator-netbeans pull request #33: -external library jna-platform-4.2.2.ja...
GitHub user jlahoda opened a pull request:
https://github.com/apache/incubator-netbeans/pull/33
-external library jna-platform-4.2.2.jar: dual-licensed by Apache Lic…
…ense v2.0 and GPLv2, picking Apache License. NOTICE entry does not seem to be needed. Maven coordinates added.
-checked Rat report; no license header in binaries-list (added)
-fixed version in -license.txt
-skimmed through the module, did not notice additional problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jlahoda/incubator-netbeans libs.jna.platform-review
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 59366e04675759c96458438e04669de896bbcd1a
Author: Jan Lahoda <jl...@netbeans.org>
Date: 2017-10-01T20:18:47Z
-external library jna-platform-4.2.2.jar: dual-licensed by Apache License v2.0 and GPLv2, picking Apache License. NOTICE entry does not seem to be needed. Maven coordinates added.
-checked Rat report; no license header in binaries-list (added)
-fixed version in -license.txt
-skimmed through the module, did not notice additional problems
----
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
So, are we adding license to binaries-list? Isn't is part of the "Problems to be solved centrally"?
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
I am no opposed to excluding binaries-list, but I'd add:
-remove existing license headers from binaries-list
-explain the decision at release time if needed
So, are you willing to work on this central problem and resolve it?
Thanks.
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
Looks good.
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
I propose #49 this unifies the headers for binaries-list to always contain the ALv2 header. I agree, that there is no real IP value in these files, but:
- there are already files with ALv2 header
- there were GPLv2-CDDL headers for oracle
- it prevents review discussions, as the header is just there
For further discussion I suggest to move discussion to #49.
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
I don't believe there is much IP value in the binaries-list files and I would not add that huge license header in all of them when they generally have 1-2 lines. The overall project license applies to all the files regardless.
So my solution would be not to add the license header to the binaries-list files and just add a RAT exclusion filter.
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
My take: If a file needs to be edited, there is no draw back in adding the license header also. There is already a mixed set (files with and without license header), so the problem would be already there.
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
Merged this pull request:
https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=0aa49fe575905f3c3eddd47c6b95194d40115174
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
Well, I think it would be good to decide if we (really) want to solve the binaries-list issue centrally, and if yes solve it. Are you willing to resolve that?
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
Regarding binaries-list, yes it is listed in the central problems (although all that means is that some of us will need to propose and implement a solution). Including the header for a single line (typically) file may be somewhat silly, but I am not sure if not adding the header is worth the discussion that will arise (given that, unlike in e.g. manifests, there is basically no issue with the header). Some of these files also already have a license header. So I was adding the headers to binaries-lists I was modifying, as that should not be wrong either way.
---
[GitHub] incubator-netbeans pull request #33: -external library jna-platform-4.2.2.ja...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/33
---
[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
The way I understood it, I will absolutely not touch "Problems to be solved centrally" because they will be dealt with entirely at some future moment.
Only reason I would care about those is if I see an Oracle copyright header. Not if they have none.
> So I was adding the headers to binaries-lists I was modifying, as that should not be wrong either way.
It kinda makes sense since you also modified the file, although not substantially (it's still the same dependency) but I would have kept it without a header because it's trivial to add them "centrally" afterwards.
---