You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Huaisi Xu (Code Review)" <ge...@cloudera.org> on 2016/03/01 01:15:40 UTC

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2643: Prevent migrating incorrectly inferred identity predicates into inline views.

Hello Juan Yu, Internal Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2339

to look at the new patch set (#2).

Change subject: IMPALA-2643: Prevent migrating incorrectly inferred identity predicates into inline views.
......................................................................

IMPALA-2643: Prevent migrating incorrectly inferred identity predicates into inline views.

Inferred predicates implicitly referring to the same expr can be migrated into an inline
view where the post-substitution predicate is an identity predicate. If such a predicate
is assigned to an plan node later, it incorrectly drops NULLs.

Change-Id: Id40524b30799d1ac994c0a44efcc1acce4ad1daf
Reviewed-on: http://gerrit.cloudera.org:8080/1720
Reviewed-by: Huaisi Xu <hx...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 0d2950200bfcee7fcbc888dc770acd0b873c98db)
---
M fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java
M fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java
M fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test
4 files changed, 72 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/39/2339/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id40524b30799d1ac994c0a44efcc1acce4ad1daf
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hx...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>