[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3844: Update to arrow 25.0.0

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3844:
URL: https://github.com/apache/arrow-datafusion/pull/3844#discussion_r997736428


##########
datafusion/core/src/physical_plan/hash_utils.rs:
##########
@@ -62,29 +62,23 @@ fn hash_decimal128<'a>(
     if array.null_count() == 0 {
         if mul_col {
             for (i, hash) in hashes_buffer.iter_mut().enumerate() {

Review Comment:
   Potentially, I think I would rather keep this as a simple upgrade PR, and address any simplifications that fall out of the new decimal abstractions as a follow up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org