[jira] [Comment Edited] (OAK-7499) Dependencies on various 'plugins'

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483654#comment-16483654 ] 

Alex Deparvu edited comment on OAK-7499 at 5/22/18 1:04 PM:
------------------------------------------------------------

I just started going through the patch. one thing that jumped at me is the creation of a new bundle for the new interfaces, wouldn't placing them in {{oak-core-spi}} be enough?
also, I saw some new methods throwing RepositoryException, I don't think that's really necessary though?

otherwise the plugins part of the code looks good to me, even though a bit big (I would have created 3 dedicated issues and pushed each plugin as it's own change). 


was (Author: alex.parvulescu):
I just started going through the patch. one thing that jumped at me is the creation of a new bundle for the new interfaces, wouldn't placing them in {{oak-core-spi}} be enough?

> Dependencies on various 'plugins'
> ---------------------------------
>
>                 Key: OAK-7499
>                 URL: https://issues.apache.org/jira/browse/OAK-7499
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: angela
>            Priority: Major
>         Attachments: OAK-7499-adjustsecuritycode.patch, OAK-7499-extractplugins.patch
>
>
> subtask of OAK-7498 to drop usage of plugin classes directly from security code base:
> - extract interfaces for managers and provider services
> - replace usage of implementenations



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)