You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/24 22:10:38 UTC
[GitHub] [incubator-superset] DiggidyDave commented on a change in pull
request #7433: Adding codecov targets and thresholds
DiggidyDave commented on a change in pull request #7433: Adding codecov targets and thresholds
URL: https://github.com/apache/incubator-superset/pull/7433#discussion_r287527761
##########
File path: .codecov.yml
##########
@@ -0,0 +1,14 @@
+coverage:
+ status:
+ project:
+ default:
+ # Commits pushed to master should not make the overall
+ # project coverage decrease by more than 1%:
+ target: auto
+ threshold: 1%
Review comment:
as noted in other comment, can we hold a hard line on this and disallow any reduction in coverage?
Also, purely out of curiosity: is there a way to bypass the check (with committer approval) in an emergency situation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org