[GitHub] [zookeeper] symat commented on a change in pull request #1807: ZOOKEEPER-4461 Migrate zookeeper-contrib and -recipes projects.

[GitBox <gi...@apache.org>]

symat commented on a change in pull request #1807:
URL: https://github.com/apache/zookeeper/pull/1807#discussion_r794491274



##########
File path: zookeeper-contrib/zookeeper-contrib-loggraph/src/main/java/org/apache/zookeeper/graph/Log4JSource.java
##########
@@ -293,7 +293,7 @@ private void init() throws IOException {
 	if ((line != null) && (m = timep.matcher(line)).lookingAt()) {
 	    starttime = timestampFromText(dateformat, m.group(1));
 	} else {
-	    throw new IOException("Invalid log4j format. First line doesn't start with time");
+	    throw new IOException("Invalid log format. First line doesn't start with time");

Review comment:
       This class has the name of "Log4JSource.java". I think we should rename it to "LogSource".
   
   I am not sure what is the purpose of this class, but this seems to parse some log messages. Am I right, that you defined 'log4j1-like' log format in the logback.xml file below?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org