You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jspwiki.apache.org by ja...@apache.org on 2008/12/05 21:48:38 UTC

svn commit: r723862 - in /incubator/jspwiki/trunk: ./ src/com/ecyrd/jspwiki/ src/com/ecyrd/jspwiki/auth/ src/com/ecyrd/jspwiki/auth/acl/ src/com/ecyrd/jspwiki/auth/authorize/ src/com/ecyrd/jspwiki/auth/permissions/ src/com/ecyrd/jspwiki/dav/ src/com/ec...

Author: jalkanen
Date: Fri Dec  5 12:48:36 2008
New Revision: 723862

URL: http://svn.apache.org/viewvc?rev=723862&view=rev
Log:
StringBuffer changed to StringBuilder to do some minor optimization.

Modified:
    incubator/jspwiki/trunk/.project
    incubator/jspwiki/trunk/ChangeLog
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/Release.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/VariableManager.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/AuthorizationManager.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/SecurityVerifier.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclEntryImpl.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclImpl.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/DefaultAclManager.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/authorize/Group.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/GroupPermission.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/PagePermission.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/WikiPermission.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/dav/DavPath.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiEvent.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiSecurityEvent.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WorkflowEvent.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/filters/SpamFilter.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormClose.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormOpen.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/PropertiesUtils.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/XHtmlElementToWikiTranslator.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/CreoleToJSPWikiTranslator.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/LinkParser.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/MarkupParser.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/AbstractReferralPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Groups.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Image.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/InsertPage.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ListLocksPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferredPagesPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferringPagesPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/SessionsPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/TableOfContents.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogArchivePlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogEntryPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogPlugin.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CleanTextRenderer.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CreoleRenderer.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rpc/json/JSONRPCManager.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rss/RSSGenerator.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/search/BasicSearchProvider.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/CookieTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkToTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/MessagesTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/SetPaginationTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/TabTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/UserProfileTag.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/TemplateManager.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/WikiJSPFilter.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/admin/SimpleAdminBean.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/migrator/JspMigrator.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/FileUtil.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/TextUtil.java
    incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/xmlrpc/MetaWeblogHandler.java
    incubator/jspwiki/trunk/tests/TranslationsCheck.java

Modified: incubator/jspwiki/trunk/.project
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/.project?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/.project (original)
+++ incubator/jspwiki/trunk/.project Fri Dec  5 12:48:36 2008
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <projectDescription>
-	<name>JSPWiki</name>
+	<name>JSPWiki-trunk</name>
 	<comment></comment>
 	<projects>
 	</projects>

Modified: incubator/jspwiki/trunk/ChangeLog
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/ChangeLog?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/ChangeLog (original)
+++ incubator/jspwiki/trunk/ChangeLog Fri Dec  5 12:48:36 2008
@@ -1,12 +1,22 @@
-2008-11-29 Harry Metske <me...@apache.org>
+2008-12-05  Janne Jalkanen <ja...@apache.org>
+
+        * 3.0.0-svn-24
+        
+        * Did a mass change of StringBuffer => StringBuilder.  It's
+        faster and in most cases a drop-in replacement.  Noticed that
+        StringBuffer.append() was taking quite a bit of time...
+        
+2008-12-04 Harry Metske <me...@apache.org>
 
         * 3.0.0-svn-23
         
         * implemented the unregisterAllLoggerMBeans method in the LoggerFactory
+        
         * added some more robustness to LoggerFactory
+        
         * made the LoggerImpl Serializable
-        * added a note to the ReleaseNotes
         
+        * added a note to the ReleaseNotes
         
 2008-12-04  Janne Jalkanen <ja...@apache.org>
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/Release.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/Release.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/Release.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/Release.java Fri Dec  5 12:48:36 2008
@@ -77,7 +77,7 @@
      *  <p>
      *  If the build identifier is empty, it is not added.
      */
-    public static final String     BUILD         = "23";
+    public static final String     BUILD         = "24";
     
     /**
      *  This is the generic version string you should use

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/VariableManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/VariableManager.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/VariableManager.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/VariableManager.java Fri Dec  5 12:48:36 2008
@@ -124,7 +124,7 @@
     public String expandVariables( WikiContext context,
                                    String      source )
     {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
 
         for( int i = 0; i < source.length(); i++ )
         {
@@ -423,7 +423,7 @@
 
         public String getInterwikilinks()
         {
-            StringBuffer res = new StringBuffer();
+            StringBuilder res = new StringBuilder();
 
             for( Iterator i = m_context.getEngine().getAllInterWikiLinks().iterator(); i.hasNext(); )
             {
@@ -438,7 +438,7 @@
 
         public String getInlinedimages()
         {
-            StringBuffer res = new StringBuffer();
+            StringBuilder res = new StringBuilder();
 
             for( Iterator i = m_context.getEngine().getAllInlinedImagePatterns().iterator(); i.hasNext(); )
             {
@@ -499,7 +499,7 @@
         public String getPagefilters()
         {
             List filters = m_context.getEngine().getFilterManager().getFilterList();
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
 
             for (Iterator i = filters.iterator(); i.hasNext();)
             {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/AuthorizationManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/AuthorizationManager.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/AuthorizationManager.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/AuthorizationManager.java Fri Dec  5 12:48:36 2008
@@ -420,7 +420,7 @@
             }
             else
             {
-                StringBuffer sb = new StringBuffer( "JSPWiki was unable to initialize the " );
+                StringBuilder sb = new StringBuilder( "JSPWiki was unable to initialize the " );
                 sb.append( "default security policy (WEB-INF/jspwiki.policy) file. " );
                 sb.append( "Please ensure that the jspwiki.policy file exists in the default location. " );
                 sb.append( "This file should exist regardless of the existance of a global policy file. " );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/SecurityVerifier.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/SecurityVerifier.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/SecurityVerifier.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/SecurityVerifier.java Fri Dec  5 12:48:36 2008
@@ -204,7 +204,7 @@
             colWidth = "67%";
         }
 
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
 
         // Write the table header
         s.append( "<table class=\"wikitable\" border=\"1\">\n" );
@@ -306,7 +306,7 @@
      */
     private final String printPermissionTest( Permission permission, Principal principal, int cols )
     {
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
         if ( permission == null )
         {
             s.append( "    <td colspan=\"" + cols + "\" align=\"center\" title=\"N/A\">" );
@@ -362,7 +362,7 @@
         // Now, print a table with JSP pages listed on the left, and
         // an evaluation of each pages' constraints for each role
         // we discovered
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
         Principal[] roles = authorizer.getRoles();
         s.append( "<table class=\"wikitable\" border=\"1\">\n" );
         s.append( "<thead>\n" );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclEntryImpl.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclEntryImpl.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclEntryImpl.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclEntryImpl.java Fri Dec  5 12:48:36 2008
@@ -144,7 +144,7 @@
      */
     public String toString()
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         Principal p = getPrincipal();
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclImpl.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclImpl.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclImpl.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/AclImpl.java Fri Dec  5 12:48:36 2008
@@ -173,7 +173,7 @@
     @SuppressWarnings("unchecked")
     public String toString()
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         for( AclEntry entry : m_entries )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/DefaultAclManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/DefaultAclManager.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/DefaultAclManager.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/acl/DefaultAclManager.java Fri Dec  5 12:48:36 2008
@@ -276,7 +276,7 @@
 
         // Now, iterate through each permission in the map and generate an ACL string
 
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
         for ( Map.Entry<String,List<Principal>>entry : permissionPrincipals.entrySet() )
         {
             String action = entry.getKey();

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/authorize/Group.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/authorize/Group.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/authorize/Group.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/authorize/Group.java Fri Dec  5 12:48:36 2008
@@ -320,7 +320,7 @@
      */
     public String toString()
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append( "(Group " + getName() + ")" );
         return sb.toString();
     }

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/GroupPermission.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/GroupPermission.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/GroupPermission.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/GroupPermission.java Fri Dec  5 12:48:36 2008
@@ -174,7 +174,7 @@
         String[] groupActions = actions.toLowerCase().split( ACTION_SEPARATOR );
         Arrays.sort( groupActions, String.CASE_INSENSITIVE_ORDER );
         m_mask = createMask( actions );
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         for( int i = 0; i < groupActions.length; i++ )
         {
             buffer.append( groupActions[i] );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/PagePermission.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/PagePermission.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/PagePermission.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/PagePermission.java Fri Dec  5 12:48:36 2008
@@ -194,7 +194,7 @@
         String[] pageActions = StringUtils.split( actions.toLowerCase(), ACTION_SEPARATOR );
         Arrays.sort( pageActions, String.CASE_INSENSITIVE_ORDER );
         m_mask = createMask( actions );
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         for( int i = 0; i < pageActions.length; i++ )
         {
             buffer.append( pageActions[i] );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/WikiPermission.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/WikiPermission.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/WikiPermission.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/auth/permissions/WikiPermission.java Fri Dec  5 12:48:36 2008
@@ -102,7 +102,7 @@
         String[] pageActions = actions.toLowerCase().split( "," );
         Arrays.sort( pageActions, String.CASE_INSENSITIVE_ORDER );
         m_mask = createMask( actions );
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         for( int i = 0; i < pageActions.length; i++ )
         {
             buffer.append( pageActions[i] );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/dav/DavPath.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/dav/DavPath.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/dav/DavPath.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/dav/DavPath.java Fri Dec  5 12:48:36 2008
@@ -149,7 +149,7 @@
      */
     public String pathPart()
     {
-        StringBuffer result = new StringBuffer( m_isAbsolute ? "/" : "" );
+        StringBuilder result = new StringBuilder( m_isAbsolute ? "/" : "" );
    
         for( int i = 0; i < m_parts.size()-(m_isDirectory ? 0 : 1); i++ )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiEvent.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiEvent.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiEvent.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiEvent.java Fri Dec  5 12:48:36 2008
@@ -149,7 +149,7 @@
      */
     public String toString()
     {
-        StringBuffer out = new StringBuffer();
+        StringBuilder out = new StringBuilder();
         out.append( "WikiEvent." );
         out.append( eventName() );
         out.append( " [source=" );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiSecurityEvent.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiSecurityEvent.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiSecurityEvent.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WikiSecurityEvent.java Fri Dec  5 12:48:36 2008
@@ -211,7 +211,7 @@
      */
     public final String toString()
     {
-        StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         msg.append( "WikiSecurityEvent." );
         msg.append(  eventName( getType() ) );
         msg.append( " [source=" + getSource().toString() );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WorkflowEvent.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WorkflowEvent.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WorkflowEvent.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/event/WorkflowEvent.java Fri Dec  5 12:48:36 2008
@@ -107,7 +107,7 @@
      */
     public final String toString()
     {
-        StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         msg.append("WorkflowEvent.");
         msg.append(eventName(getType()));
         msg.append(" [source=" + getSource().toString());

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/filters/SpamFilter.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/filters/SpamFilter.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/filters/SpamFilter.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/filters/SpamFilter.java Fri Dec  5 12:48:36 2008
@@ -970,7 +970,7 @@
      */
     private static String getUniqueID()
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         Random rand = new Random();
 
         for( int i = 0; i < 6; i++ )
@@ -1133,7 +1133,7 @@
         WikiContext ctx = WikiContextFactory.findContext(pageContext);
         WikiEngine engine = ctx.getEngine();
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         if (engine.getContentEncoding().equals("UTF-8"))
         {
             sb.append("<input name='encodingcheck' type='hidden' value='\u3041' />\n");

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormClose.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormClose.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormClose.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormClose.java Fri Dec  5 12:48:36 2008
@@ -45,7 +45,7 @@
     public String execute( WikiContext ctx, Map params )
         throws PluginException
     {
-        StringBuffer tags = new StringBuffer();
+        StringBuilder tags = new StringBuilder();
         tags.append( "</form>\n" );
         tags.append( "</div>" );
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormOpen.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormOpen.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormOpen.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/forms/FormOpen.java Fri Dec  5 12:48:36 2008
@@ -139,7 +139,7 @@
         info.setName( formName );
         info.setAction( submitServlet );
 
-        StringBuffer tag = new StringBuffer( 40 );
+        StringBuilder tag = new StringBuilder( 40 );
         tag.append( "<div class=\"wikiform\">\n" );
         tag.append( "<form action=\"" + submitServlet );
         tag.append( "\" name=\"" + formName );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/PropertiesUtils.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/PropertiesUtils.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/PropertiesUtils.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/PropertiesUtils.java Fri Dec  5 12:48:36 2008
@@ -85,7 +85,7 @@
     public static String saveConvert( String string, boolean encodeWhiteSpace )
     {
         int i = string.length();
-        StringBuffer stringbuffer = new StringBuffer( i * 2 );
+        StringBuilder stringbuffer = new StringBuilder( i * 2 );
         for( int i3 = 0; i3 < i; i3++ )
         {
             char c = string.charAt( i3 );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/XHtmlElementToWikiTranslator.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/XHtmlElementToWikiTranslator.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/XHtmlElementToWikiTranslator.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/htmltowiki/XHtmlElementToWikiTranslator.java Fri Dec  5 12:48:36 2008
@@ -753,7 +753,7 @@
 
     private String propsToStyleString( Map styleProps )
     {
-        StringBuffer style = new StringBuffer();
+        StringBuilder style = new StringBuilder();
         for( Iterator i = styleProps.entrySet().iterator(); i.hasNext(); )
         {
             Map.Entry entry = (Map.Entry)i.next();
@@ -880,7 +880,7 @@
      */
     private String augmentedWikiLinkMapToString( Map attributesMap )
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         for ( Iterator itr = attributesMap.entrySet().iterator(); itr.hasNext(); )
         {
@@ -1024,7 +1024,7 @@
     private static class LiStack
     {
 
-        private StringBuffer m_li = new StringBuffer();
+        private StringBuilder m_li = new StringBuilder();
 
         public void push( String c )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/CreoleToJSPWikiTranslator.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/CreoleToJSPWikiTranslator.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/CreoleToJSPWikiTranslator.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/CreoleToJSPWikiTranslator.java Fri Dec  5 12:48:36 2008
@@ -283,7 +283,7 @@
     private static String translateLists(String content, String sourceSymbol, String targetSymbol, String sourceSymbol2)
     {
         String[] lines = content.split("\n");
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         int counter = 0;
         int inList = -1;
         for (int i = 0; i < lines.length; i++)

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/LinkParser.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/LinkParser.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/LinkParser.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/LinkParser.java Fri Dec  5 12:48:36 2008
@@ -532,7 +532,7 @@
          */
         public String toString()
         {
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
             sb.append( '[' );
             sb.append( m_text );
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/MarkupParser.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/MarkupParser.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/MarkupParser.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/parser/MarkupParser.java Fri Dec  5 12:48:36 2008
@@ -280,7 +280,7 @@
         if( link == null ) return null;
 
         link = link.trim();
-        StringBuffer clean = new StringBuffer(link.length());
+        StringBuilder clean = new StringBuilder(link.length());
 
         //
         //  Remove non-alphanumeric characters that should not

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/AbstractReferralPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/AbstractReferralPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/AbstractReferralPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/AbstractReferralPlugin.java Fri Dec  5 12:48:36 2008
@@ -315,7 +315,7 @@
         if( links == null || links.isEmpty() )
             return "";
 
-        StringBuffer output = new StringBuffer();
+        StringBuilder output = new StringBuilder();
 
         Iterator it     = links.iterator();
         int      count  = 0;

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Groups.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Groups.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Groups.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Groups.java Fri Dec  5 12:48:36 2008
@@ -60,7 +60,7 @@
         Principal[] groups = groupMgr.getRoles();
         Arrays.sort( groups, COMPARATOR );
 
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
         
         for ( int i = 0; i < groups.length; i++ )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Image.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Image.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Image.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/Image.java Fri Dec  5 12:48:36 2008
@@ -142,7 +142,7 @@
             throw new PluginException( "Attachment info failed: "+e.getMessage() );
         }
 
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
 
         result.append( "<table border=\"0\" class=\""+cssclass+"\"" );
         //if( align != null ) result.append(" align=\""+align+"\"");

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/InsertPage.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/InsertPage.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/InsertPage.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/InsertPage.java Fri Dec  5 12:48:36 2008
@@ -84,7 +84,7 @@
         WikiEngine engine = context.getEngine();
         ResourceBundle rb = context.getBundle(WikiPlugin.CORE_PLUGINS_RESOURCEBUNDLE);
 
-        StringBuffer res = new StringBuffer();
+        StringBuilder res = new StringBuilder();
 
         String clazz        = (String) params.get( PARAM_CLASS );
         String includedPage = (String) params.get( PARAM_PAGENAME );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ListLocksPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ListLocksPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ListLocksPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ListLocksPlugin.java Fri Dec  5 12:48:36 2008
@@ -48,7 +48,7 @@
     public String execute( WikiContext context, Map params )
         throws PluginException
     {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
 
         PageManager mgr = context.getEngine().getPageManager();
         List locks = mgr.getActiveLocks();

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferredPagesPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferredPagesPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferredPagesPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferredPagesPlugin.java Fri Dec  5 12:48:36 2008
@@ -52,7 +52,7 @@
     private WikiEngine     m_engine;
     private int            m_depth;
     private HashSet<String> m_exists  = new HashSet<String>();
-    private StringBuffer   m_result  = new StringBuffer(1024);
+    private StringBuilder   m_result  = new StringBuilder(1024);
     private PatternMatcher m_matcher = new Perl5Matcher();
     private Pattern        m_includePattern;
     private Pattern        m_excludePattern;

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferringPagesPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferringPagesPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferringPagesPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/ReferringPagesPlugin.java Fri Dec  5 12:48:36 2008
@@ -79,7 +79,7 @@
         String pageName = (String)params.get( PARAM_PAGE );
         ResourceBundle rb = context.getBundle(WikiPlugin.CORE_PLUGINS_RESOURCEBUNDLE);
         
-        StringBuffer result = new StringBuffer( 256 );
+        StringBuilder result = new StringBuilder( 256 );
         
         if( pageName == null )
         {
@@ -137,7 +137,7 @@
             {
                 if( m_show.equals( PARAM_SHOW_VALUE_COUNT ) )
                 {
-                    result = new StringBuffer();
+                    result = new StringBuilder();
                     result.append( links.size() );
                     if( m_lastModified )
                     {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/SessionsPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/SessionsPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/SessionsPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/SessionsPlugin.java Fri Dec  5 12:48:36 2008
@@ -67,7 +67,7 @@
         if ( "users".equals( prop ) )
         {
             Principal[] principals = WikiSession.userPrincipals( engine );
-            StringBuffer s = new StringBuffer();
+            StringBuilder s = new StringBuilder();
             for ( int i = 0; i < principals.length; i++ )
             {
                 s.append(principals[i].getName() + ", ");
@@ -105,7 +105,7 @@
             }
             //
             //
-            StringBuffer s = new StringBuffer();
+            StringBuilder s = new StringBuilder();
             Iterator entries = distinctPrincipals.entrySet().iterator();
             while (entries.hasNext())
             {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/TableOfContents.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/TableOfContents.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/TableOfContents.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/TableOfContents.java Fri Dec  5 12:48:36 2008
@@ -66,7 +66,7 @@
 
     private static final String VAR_ALREADY_PROCESSING = "__TableOfContents.processing";
 
-    StringBuffer m_buf = new StringBuffer();
+    StringBuilder m_buf = new StringBuilder();
     private boolean m_usingNumberedList = false;
     private String m_prefix = "";
     private int m_starting = 0;
@@ -159,7 +159,7 @@
             //return rb.getString("tableofcontents.title");
             return "<a href=\"#section-TOC\" class=\"toc\">"+rb.getString("tableofcontents.title")+"</a>";
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         sb.append("<div class=\"toc\">\n");
         sb.append("<div class=\"collapsebox\">\n");

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogArchivePlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogArchivePlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogArchivePlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogArchivePlugin.java Fri Dec  5 12:48:36 2008
@@ -72,7 +72,7 @@
                                                 context.getURL( WikiContext.VIEW, weblogName,
                                                                 "weblog.startDate='ddMMyy'&amp;weblog.days=%d")+"'");
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         sb.append( "<div class=\"weblogarchive\">\n" );
         

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogEntryPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogEntryPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogEntryPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogEntryPlugin.java Fri Dec  5 12:48:36 2008
@@ -100,7 +100,7 @@
         }
         WikiEngine engine = context.getEngine();
         
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         String entryText = (String) params.get(PARAM_ENTRYTEXT);
         if( entryText == null ) 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogPlugin.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogPlugin.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogPlugin.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/plugin/WeblogPlugin.java Fri Dec  5 12:48:36 2008
@@ -252,7 +252,7 @@
         stopTime.set( Calendar.MINUTE, 59 );
         stopTime.set( Calendar.SECOND, 59 );
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         try
         {
@@ -297,7 +297,7 @@
      *  @param entry
      *  @throws ProviderException
      */
-    private void addEntryHTML(WikiContext context, DateFormat entryFormat, boolean hasComments, StringBuffer buffer, WikiPage entry) 
+    private void addEntryHTML(WikiContext context, DateFormat entryFormat, boolean hasComments, StringBuilder buffer, WikiPage entry) 
         throws ProviderException
     {
         WikiEngine engine = context.getEngine();

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CleanTextRenderer.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CleanTextRenderer.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CleanTextRenderer.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CleanTextRenderer.java Fri Dec  5 12:48:36 2008
@@ -64,7 +64,7 @@
     public String getString()
         throws IOException
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         
         try
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CreoleRenderer.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CreoleRenderer.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CreoleRenderer.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/render/CreoleRenderer.java Fri Dec  5 12:48:36 2008
@@ -93,11 +93,11 @@
     }
     
     /**
-     * Renders an element into the StringBuffer given
+     * Renders an element into the StringBuilder given
      * @param ce
      * @param sb
      */
-    private void renderElement( Element ce, StringBuffer sb )
+    private void renderElement( Element ce, StringBuilder sb )
     {
         String endEl = EMPTY_STRING;
         for( int i = 0; i < ELEMENTS.length; i+=3 )
@@ -197,7 +197,7 @@
      */
     public String getString() throws IOException
     {
-        StringBuffer sb = new StringBuffer(1000);
+        StringBuilder sb = new StringBuilder(1000);
         
         Element ce = m_document.getRootElement();
         

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rpc/json/JSONRPCManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rpc/json/JSONRPCManager.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rpc/json/JSONRPCManager.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rpc/json/JSONRPCManager.java Fri Dec  5 12:48:36 2008
@@ -81,7 +81,7 @@
      */
     public static String emitJSONCall( WikiContext context, RPCCallable c, String function, String params )
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append("<script>");
         sb.append("var result = jsonrpc."+getId(c)+"."+function+"("+params+");\r\n");
         sb.append("document.write(result);\r\n");

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rss/RSSGenerator.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rss/RSSGenerator.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rss/RSSGenerator.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/rss/RSSGenerator.java Fri Dec  5 12:48:36 2008
@@ -204,7 +204,7 @@
     private String getAttachmentDescription( Attachment att )
     {
         String author = getAuthor(att);
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         if( att.getVersion() != 1 )
         {
@@ -228,7 +228,7 @@
 
     private String getPageDescription( WikiPage page )
     {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         String author = getAuthor(page);
 
         WikiContext ctx = m_engine.getWikiContextFactory().newViewContext( null, null, page );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/search/BasicSearchProvider.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/search/BasicSearchProvider.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/search/BasicSearchProvider.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/search/BasicSearchProvider.java Fri Dec  5 12:48:36 2008
@@ -135,7 +135,7 @@
                 return "";
             }
 
-            StringBuffer attachmentNames = new StringBuffer();
+            StringBuilder attachmentNames = new StringBuilder();
             for( Iterator it = attachments.iterator(); it.hasNext(); )
             {
                 Attachment att = (Attachment) it.next();

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/CookieTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/CookieTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/CookieTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/CookieTag.java Fri Dec  5 12:48:36 2008
@@ -358,7 +358,7 @@
      */
     private String encodeValues( Map values )
     {
-        StringBuffer rval = new StringBuffer();
+        StringBuilder rval = new StringBuilder();
         if( values == null || values.size() == 0 )
         {
             return rval.toString();

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkTag.java Fri Dec  5 12:48:36 2008
@@ -317,7 +317,7 @@
         {
             return addTo;
         }
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         Iterator it = params.entrySet().iterator();
         while( it.hasNext() )
         {
@@ -421,7 +421,7 @@
             JspWriter out = pageContext.getOut();
             String url = figureOutURL();
 
-            StringBuffer sb = new StringBuffer( 20 );
+            StringBuilder sb = new StringBuilder( 20 );
 
             sb.append( (m_class != null)   ? "class=\""+m_class+"\" " : "" );
             sb.append( (m_style != null)   ? "style=\""+m_style+"\" " : "" );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkToTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkToTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkToTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/LinkToTag.java Fri Dec  5 12:48:36 2008
@@ -112,7 +112,7 @@
         }
         else
         {
-            StringBuffer params = new StringBuffer();
+            StringBuilder params = new StringBuilder();
             if( getVersion() != null ) params.append( "version="+getVersion() );
             if( getTemplate() != null ) params.append( (params.length()>0?"&amp;":"") + "skin="+getTemplate() );
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/MessagesTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/MessagesTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/MessagesTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/MessagesTag.java Fri Dec  5 12:48:36 2008
@@ -127,7 +127,7 @@
             
             if ( messages.length > 0 )
             {
-                StringBuffer sb = new StringBuffer();
+                StringBuilder sb = new StringBuilder();
                 if ( messages.length == 1 )
                 {
                     sb.append( "<div class=\"" + m_div + "\">" + m_prefix + TextUtil.replaceEntities(messages[0]) + "</div>" );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/SetPaginationTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/SetPaginationTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/SetPaginationTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/SetPaginationTag.java Fri Dec  5 12:48:36 2008
@@ -129,7 +129,7 @@
     {
         if( m_total <= m_pagesize ) return SKIP_BODY;
 
-        StringBuffer pagination = new StringBuffer();
+        StringBuilder pagination = new StringBuilder();
 
         if( m_start > m_total ) m_start = m_total;
         if( m_start < ALLITEMS ) m_start = 0;
@@ -233,15 +233,15 @@
      * @param onclick : link text
      *
      **/
-    private void appendLink( StringBuffer sb, int page, String fmttextkey )
+    private void appendLink( StringBuilder sb, int page, String fmttextkey )
     {
         appendLink2( sb, page, LocaleSupport.getLocalizedMessage( pageContext, fmttextkey ) );
     }
-    private void appendLink( StringBuffer sb, int page, int paginationblock )
+    private void appendLink( StringBuilder sb, int page, int paginationblock )
     {
         appendLink2( sb, page, Integer.toString( paginationblock ) );
     }
-    private void appendLink2( StringBuffer sb, int page, String text )
+    private void appendLink2( StringBuilder sb, int page, String text )
     {
         sb.append( "<a title=\"" );
         if( page == ALLITEMS )

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/TabTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/TabTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/TabTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/TabTag.java Fri Dec  5 12:48:36 2008
@@ -132,7 +132,7 @@
 
         if( !parent.isStateGenerateTabBody() ) return SKIP_BODY;
 
-        StringBuffer sb = new StringBuffer(32);
+        StringBuilder sb = new StringBuilder(32);
 
         sb.append( "<div id=\""+ getId() + "\"" );
 
@@ -161,7 +161,7 @@
     {
         TabbedSectionTag parent=getParentTag( TabbedSectionTag.class );
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         if( parent.isStateFindDefaultTab() )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/UserProfileTag.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/UserProfileTag.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/UserProfileTag.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/tags/UserProfileTag.java Fri Dec  5 12:48:36 2008
@@ -236,7 +236,7 @@
             return rb.getString("userprofile.nogroups");
         }
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         for ( int i = 0; i < tempRoles.size(); i++ )
         {
             String name = tempRoles.get( i );
@@ -277,7 +277,7 @@
             return rb.getString( "userprofile.noroles" );
         }
 
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         for ( int i = 0; i < tempRoles.size(); i++ )
         {
             String name = tempRoles.get( i );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/TemplateManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/TemplateManager.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/TemplateManager.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/TemplateManager.java Fri Dec  5 12:48:36 2008
@@ -688,7 +688,7 @@
      */
     private static String getJSLocalizedStrings( WikiContext context )
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         sb.append( "var LocalizedStrings = {\n");
 

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/WikiJSPFilter.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/WikiJSPFilter.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/WikiJSPFilter.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/WikiJSPFilter.java Fri Dec  5 12:48:36 2008
@@ -228,7 +228,7 @@
         
         String[] resources = TemplateManager.getResourceRequests( wikiContext, type );
         
-        StringBuffer concat = new StringBuffer( resources.length * 40 );
+        StringBuilder concat = new StringBuilder( resources.length * 40 );
         
         for( int i = 0; i < resources.length; i++  )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/admin/SimpleAdminBean.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/admin/SimpleAdminBean.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/admin/SimpleAdminBean.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/admin/SimpleAdminBean.java Fri Dec  5 12:48:36 2008
@@ -72,7 +72,7 @@
     {
         MBeanInfo info = getMBeanInfo();
         MBeanAttributeInfo[] attributes = info.getAttributes();
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         
         for( int i = 0; i < attributes.length; i++ )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/migrator/JspMigrator.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/migrator/JspMigrator.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/migrator/JspMigrator.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/ui/migrator/JspMigrator.java Fri Dec  5 12:48:36 2008
@@ -139,7 +139,7 @@
     {
         // Read in the file
         FileReader reader = new FileReader( src );
-        StringBuffer s = new StringBuffer();
+        StringBuilder s = new StringBuilder();
         int ch = 0;
         while ( (ch = reader.read()) != -1 )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/FileUtil.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/FileUtil.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/FileUtil.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/FileUtil.java Fri Dec  5 12:48:36 2008
@@ -116,7 +116,7 @@
         throws IOException,
                InterruptedException
     {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
 
         log.info("Running simple command "+command+" in "+directory);
 
@@ -137,7 +137,7 @@
                 result.append( line+"\n");
             }
 
-            StringBuffer error = new StringBuffer();
+            StringBuilder error = new StringBuilder();
             while( (line = stderr.readLine()) != null )
             {
                 error.append( line+"\n");
@@ -309,7 +309,7 @@
     public static String getThrowingMethod( Throwable t )
     {
         StackTraceElement[] trace = t.getStackTrace();
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         if( trace == null || trace.length == 0 )
         {

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/TextUtil.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/TextUtil.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/TextUtil.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/util/TextUtil.java Fri Dec  5 12:48:36 2008
@@ -50,7 +50,7 @@
      */
     protected static String urlEncode( byte[] rs )
     {
-        StringBuffer result = new StringBuffer(rs.length*2);
+        StringBuilder result = new StringBuilder(rs.length*2);
 
         // Does the URLEncoding.  We could use the java.net one, but
         // it does not eat byte[]s.
@@ -311,7 +311,7 @@
         if ( src == null || dest == null ) throw new NullPointerException();
         if ( src.length() == 0 ) return orig;
 
-        StringBuffer res = new StringBuffer(orig.length()+20); // Pure guesswork
+        StringBuilder res = new StringBuilder(orig.length()+20); // Pure guesswork
         int start = 0;
         int end = 0;
         int last = 0;
@@ -342,7 +342,7 @@
     {
         if( orig == null ) return null;
 
-        StringBuffer buf = new StringBuffer(orig);
+        StringBuilder buf = new StringBuilder(orig);
 
         buf.replace( start, end, text );
 
@@ -361,7 +361,7 @@
     {
         if( orig == null ) return null;
 
-        StringBuffer res = new StringBuffer();
+        StringBuilder res = new StringBuilder();
         int start        = 0;
         int end          = 0;
         int last         = 0;
@@ -509,7 +509,7 @@
      */
     public static String normalizePostData( String postData )
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         for( int i = 0; i < postData.length(); i++ )
         {
@@ -591,7 +591,7 @@
      */
     public static String beautifyString( String s, String space )
     {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
 
         if( s == null || s.length() == 0 ) return "";
 
@@ -744,7 +744,7 @@
      */
     public static String repeatString( String what, int times )
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         for( int i = 0; i < times; i++ )
         {
@@ -764,7 +764,7 @@
      */
     public static String native2Ascii(String s)
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         for(int i = 0; i < s.length(); i++)
         {
             char aChar = s.charAt(i);
@@ -805,7 +805,7 @@
      */
     public static String toHexString( byte[] bytes )
     {
-        StringBuffer sb = new StringBuffer( bytes.length*2 );
+        StringBuilder sb = new StringBuilder( bytes.length*2 );
         for( int i = 0; i < bytes.length; i++ )
         {
             sb.append( toHex(bytes[i] >> 4) );

Modified: incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/xmlrpc/MetaWeblogHandler.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/xmlrpc/MetaWeblogHandler.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/xmlrpc/MetaWeblogHandler.java (original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/xmlrpc/MetaWeblogHandler.java Fri Dec  5 12:48:36 2008
@@ -271,7 +271,7 @@
 
             WikiContext context = engine.getWikiContextFactory().newViewContext( null, null, entryPage );
 
-            StringBuffer text = new StringBuffer();
+            StringBuilder text = new StringBuilder();
             text.append( "!"+content.get("title") );
             text.append( "\n\n" );
             text.append( content.get("description") );
@@ -368,7 +368,7 @@
 
             WikiContext context = engine.getWikiContextFactory().newViewContext( null, null, entryPage );
 
-            StringBuffer text = new StringBuffer();
+            StringBuilder text = new StringBuilder();
             text.append( "!"+content.get("title") );
             text.append( "\n\n" );
             text.append( content.get("description") );

Modified: incubator/jspwiki/trunk/tests/TranslationsCheck.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/tests/TranslationsCheck.java?rev=723862&r1=723861&r2=723862&view=diff
==============================================================================
--- incubator/jspwiki/trunk/tests/TranslationsCheck.java (original)
+++ incubator/jspwiki/trunk/tests/TranslationsCheck.java Fri Dec  5 12:48:36 2008
@@ -106,7 +106,7 @@
 
         String msg = "Properties in file " + source2;
         System.out.println(msg);
-        StringBuffer sb = new StringBuffer(msg.length());
+        StringBuilder sb = new StringBuilder(msg.length());
         for (int i = 0; i < msg.length(); i++)
             sb.append("-");
         System.out.println(sb.toString());