You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/26 03:34:27 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp
HyukjinKwon commented on a change in pull request #28342:
URL: https://github.com/apache/spark/pull/28342#discussion_r415203732
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -62,7 +61,18 @@ trait TimeZoneAwareExpression extends Expression {
* There is no code generation since this expression should get constant folded by the optimizer.
*/
@ExpressionDescription(
- usage = "_FUNC_() - Returns the current date at the start of query evaluation.",
+ usage = """
+ _FUNC_() - Returns the current date at the start of query evaluation.
+
+ _FUNC_ - Returns the current date at the start of query evaluation.
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_();
+ 2020-04-25
+ > SELECT _FUNC_;
Review comment:
Do you remember when we started to support this syntax? I roughly remember it was added relatively recently. If the added version is different, it might be best to note it in `note` while we're here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org