You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by tomatophantastico <gi...@git.apache.org> on 2017/07/21 22:17:55 UTC

[GitHub] metamodel pull request #149: Feature/jdbc composite relations

GitHub user tomatophantastico opened a pull request:

    https://github.com/apache/metamodel/pull/149

    Feature/jdbc composite relations

    A fix for METAMODEL-1145.
    
    The test might not be in the best location.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tomatophantastico/metamodel feature/jdbcCompositeRelations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit c7f99b04ce2becd9ee7579e5f748c2c1d945e25d
Author: Jörg Unbehauen <jo...@unbehauen.net>
Date:   2017-07-17T13:19:46Z

    Test case for composite PK/FK relations.
    
    PK/FK relations are not correctly resolved, they are returned as a pairwise, cartesian product of their keys.
    
    Test is in H2 database as SQL is used here, the problem should appear in all DBMS though.

commit 59fa48dbf8e0558b26f2f665b4cee8edd42c435a
Author: Jörg Unbehauen <jo...@unbehauen.net>
Date:   2017-07-17T13:21:45Z

    and the fix, which is grouping the result set along the tables and pairwise listing of the columns

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel issue #149: Feature/jdbc composite relations

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the issue:

    https://github.com/apache/metamodel/pull/149
  
    The solution looks good to me, but it's not really following our code conventions. Because of the small size, I can fix that up before patching, so no problem. But I see you're taking on a few other PRs too, so maybe it's good for you to pick up our code formatting rules etc. to avoid issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request #149: Feature/jdbc composite relations

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---