You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Adrien Grand (Jira)" <ji...@apache.org> on 2020/08/12 12:31:00 UTC

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

    [ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176313#comment-17176313 ] 

Adrien Grand commented on LUCENE-9455:
--------------------------------------

+1

> ExitableTermsEnum (in ExitableDirectoryReader) should sample next()
> -------------------------------------------------------------------
>
>                 Key: LUCENE-9455
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9455
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: David Smiley
>            Priority: Major
>
> ExitableTermsEnum calls "checkAndThrow" on *every* call to next().  This is too expensive; it should sample.  I observed ElasticSearch uses the same approach; I think Lucene would benefit from this:
> https://github.com/elastic/elasticsearch/blob/4af4eb99e18fdaadac879b1223e986227dd2ee71/server/src/main/java/org/elasticsearch/search/internal/ExitableDirectoryReader.java#L151
> CC [~jimczi]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org