You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/02/04 08:47:39 UTC
[jira] [Updated] (REEF-1186) Remove wrong inject annotation on OperatorTopologyImpl

     [ https://issues.apache.org/jira/browse/REEF-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun updated REEF-1186:
--------------------------------
    Description: 
*OperatorTopologyImpl* is annotated as `@Inject`, but it's not injectable due to the repeated argument types in its constructor. It will cause `ClassHierarchyException`. 
{code}
-  @Inject
   public OperatorTopologyImpl(
      final Class<? extends Name<String>> groupName,
      final Class<? extends Name<String>> operName, final String selfId,
      final String driverId, final Sender sender, final int version) {
{code}

Also, all eight usages of *OperatorTopologyImpl* uses *new* like the following.
{code}
new OperatorTopologyImpl(this.groupName, this.operName, selfId, driverId, new Sender(netService), version);
{code}

Since it seems to be a typo, this issue removes the wrong annotation.

  was:
*OperatorTopologyImpl* is annotated as `@Inject`, but it's not injectable due to the repeated argument types in its constructor. It will cause `ClassHierarchyException`. 
{code}
-  @Inject
   public OperatorTopologyImpl(
      final Class<? extends Name<String>> groupName,
      final Class<? extends Name<String>> operName, final String selfId,
      final String driverId, final Sender sender, final int version) {
{code}

Also, all the usage pattern of *OperatorTopologyImpl* is using *new*.
{code}
new OperatorTopologyImpl(this.groupName, this.operName, selfId, driverId, new Sender(netService), version);
{code}

Since it seems to be a typo, this issue removes the wrong annotation.


> Remove wrong inject annotation on OperatorTopologyImpl
> ------------------------------------------------------
>
>                 Key: REEF-1186
>                 URL: https://issues.apache.org/jira/browse/REEF-1186
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF-IO
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>
> *OperatorTopologyImpl* is annotated as `@Inject`, but it's not injectable due to the repeated argument types in its constructor. It will cause `ClassHierarchyException`. 
> {code}
> -  @Inject
>    public OperatorTopologyImpl(
>       final Class<? extends Name<String>> groupName,
>       final Class<? extends Name<String>> operName, final String selfId,
>       final String driverId, final Sender sender, final int version) {
> {code}
> Also, all eight usages of *OperatorTopologyImpl* uses *new* like the following.
> {code}
> new OperatorTopologyImpl(this.groupName, this.operName, selfId, driverId, new Sender(netService), version);
> {code}
> Since it seems to be a typo, this issue removes the wrong annotation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)