[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5802: kvm: don't always force scsi controller for aarch64 VMs

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5802:
URL: https://github.com/apache/cloudstack/pull/5802#discussion_r774321183



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3713,10 +3713,6 @@ public boolean isCentosHost() {
             return null;
         }
 
-        if (_guestCpuArch != null && _guestCpuArch.equals("aarch64")) {

Review comment:
       Instead of removing, is it better to move this block to the default else case, because the default case always returns IDE ? I'm thinking in terms of backward compatibility




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org