You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Ryan Fishel <ry...@cloudera.com> on 2013/11/04 18:23:23 UTC
Review Request 15210: ACCUMULO-1658 Review
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-1658
https://issues.apache.org/jira/browse/ACCUMULO-1658
Repository: accumulo
Description
-------
Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
Diffs
-----
test/system/auto/TestUtils.py 4b5efdf
test/system/continuous/agitator.pl c074665
test/system/continuous/continuous-env.sh.example 76f2632
test/system/continuous/magitator.pl a0cab60
test/system/continuous/mapred-setup.sh e14d221
test/system/continuous/start-stats.sh 5ece7f5
test/system/randomwalk/bin/reset-cluster.sh 83dfcee
test/system/randomwalk/bin/start-all.sh 67296de
test/system/randomwalk/bin/start-local.sh c02b942
test/system/scalability/run.py d0f9f51
Diff: https://reviews.apache.org/r/15210/diff/
Testing
-------
Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
Thanks,
Ryan Fishel
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by John Vines <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/#review28119
-----------------------------------------------------------
Ship it!
Ship It!
- John Vines
On Nov. 4, 2013, 5:23 p.m., Ryan Fishel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15210/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 5:23 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1658
> https://issues.apache.org/jira/browse/ACCUMULO-1658
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
>
>
> Diffs
> -----
>
> test/system/auto/TestUtils.py 4b5efdf
> test/system/continuous/agitator.pl c074665
> test/system/continuous/continuous-env.sh.example 76f2632
> test/system/continuous/magitator.pl a0cab60
> test/system/continuous/mapred-setup.sh e14d221
> test/system/continuous/start-stats.sh 5ece7f5
> test/system/randomwalk/bin/reset-cluster.sh 83dfcee
> test/system/randomwalk/bin/start-all.sh 67296de
> test/system/randomwalk/bin/start-local.sh c02b942
> test/system/scalability/run.py d0f9f51
>
> Diff: https://reviews.apache.org/r/15210/diff/
>
>
> Testing
> -------
>
> Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
>
> Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
>
>
> Thanks,
>
> Ryan Fishel
>
>
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/#review28120
-----------------------------------------------------------
test/system/auto/TestUtils.py
<https://reviews.apache.org/r/15210/#comment54707>
Please don't include formatting fixes unrelated to the patch.
test/system/continuous/mapred-setup.sh
<https://reviews.apache.org/r/15210/#comment54708>
please don't include formatting fixes unrelated to the patch.
test/system/randomwalk/bin/start-all.sh
<https://reviews.apache.org/r/15210/#comment54709>
please don't include formatting changes unrelated to the patch.
- Sean Busbey
On Nov. 4, 2013, 5:23 p.m., Ryan Fishel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15210/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 5:23 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1658
> https://issues.apache.org/jira/browse/ACCUMULO-1658
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
>
>
> Diffs
> -----
>
> test/system/auto/TestUtils.py 4b5efdf
> test/system/continuous/agitator.pl c074665
> test/system/continuous/continuous-env.sh.example 76f2632
> test/system/continuous/magitator.pl a0cab60
> test/system/continuous/mapred-setup.sh e14d221
> test/system/continuous/start-stats.sh 5ece7f5
> test/system/randomwalk/bin/reset-cluster.sh 83dfcee
> test/system/randomwalk/bin/start-all.sh 67296de
> test/system/randomwalk/bin/start-local.sh c02b942
> test/system/scalability/run.py d0f9f51
>
> Diff: https://reviews.apache.org/r/15210/diff/
>
>
> Testing
> -------
>
> Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
>
> Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
>
>
> Thanks,
>
> Ryan Fishel
>
>
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/#review28123
-----------------------------------------------------------
test/system/scalability/run.py
<https://reviews.apache.org/r/15210/#comment54710>
Looks like this is another whitespace fix unrelated to original issue
- Sean Busbey
On Nov. 4, 2013, 5:23 p.m., Ryan Fishel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15210/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 5:23 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1658
> https://issues.apache.org/jira/browse/ACCUMULO-1658
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
>
>
> Diffs
> -----
>
> test/system/auto/TestUtils.py 4b5efdf
> test/system/continuous/agitator.pl c074665
> test/system/continuous/continuous-env.sh.example 76f2632
> test/system/continuous/magitator.pl a0cab60
> test/system/continuous/mapred-setup.sh e14d221
> test/system/continuous/start-stats.sh 5ece7f5
> test/system/randomwalk/bin/reset-cluster.sh 83dfcee
> test/system/randomwalk/bin/start-all.sh 67296de
> test/system/randomwalk/bin/start-local.sh c02b942
> test/system/scalability/run.py d0f9f51
>
> Diff: https://reviews.apache.org/r/15210/diff/
>
>
> Testing
> -------
>
> Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
>
> Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
>
>
> Thanks,
>
> Ryan Fishel
>
>
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by Ryan Fishel <ry...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 6:28 p.m.)
Review request for accumulo.
Changes
-------
Updated to reflect changes requested by Sean Busbey.
Bugs: ACCUMULO-1658
https://issues.apache.org/jira/browse/ACCUMULO-1658
Repository: accumulo
Description
-------
Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
Diffs (updated)
-----
test/system/auto/TestUtils.py 4b5efdf
test/system/continuous/agitator.pl c074665
test/system/continuous/continuous-env.sh.example 76f2632
test/system/continuous/magitator.pl a0cab60
test/system/continuous/mapred-setup.sh e14d221
test/system/continuous/start-stats.sh 5ece7f5
test/system/randomwalk/bin/reset-cluster.sh 83dfcee
test/system/randomwalk/bin/start-all.sh 67296de
test/system/randomwalk/bin/start-local.sh c02b942
test/system/scalability/run.py d0f9f51
Diff: https://reviews.apache.org/r/15210/diff/
Testing
-------
Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
Thanks,
Ryan Fishel
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by Sean Busbey <se...@manvsbeard.com>.
> On Nov. 4, 2013, 5:49 p.m., Sean Busbey wrote:
> > Ship It!
(after removal of aforementioned whitespace changes)
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/#review28121
-----------------------------------------------------------
On Nov. 4, 2013, 5:23 p.m., Ryan Fishel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15210/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 5:23 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1658
> https://issues.apache.org/jira/browse/ACCUMULO-1658
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
>
>
> Diffs
> -----
>
> test/system/auto/TestUtils.py 4b5efdf
> test/system/continuous/agitator.pl c074665
> test/system/continuous/continuous-env.sh.example 76f2632
> test/system/continuous/magitator.pl a0cab60
> test/system/continuous/mapred-setup.sh e14d221
> test/system/continuous/start-stats.sh 5ece7f5
> test/system/randomwalk/bin/reset-cluster.sh 83dfcee
> test/system/randomwalk/bin/start-all.sh 67296de
> test/system/randomwalk/bin/start-local.sh c02b942
> test/system/scalability/run.py d0f9f51
>
> Diff: https://reviews.apache.org/r/15210/diff/
>
>
> Testing
> -------
>
> Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
>
> Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
>
>
> Thanks,
>
> Ryan Fishel
>
>
Re: Review Request 15210: ACCUMULO-1658 Review
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15210/#review28121
-----------------------------------------------------------
Ship it!
Ship It!
- Sean Busbey
On Nov. 4, 2013, 5:23 p.m., Ryan Fishel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15210/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 5:23 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1658
> https://issues.apache.org/jira/browse/ACCUMULO-1658
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Patch for Apache ticket ACCUMULO-1658, system integration tests should default ACCUMULO_CONF_DIR to ACCUMULO_HOME/conf
>
>
> Diffs
> -----
>
> test/system/auto/TestUtils.py 4b5efdf
> test/system/continuous/agitator.pl c074665
> test/system/continuous/continuous-env.sh.example 76f2632
> test/system/continuous/magitator.pl a0cab60
> test/system/continuous/mapred-setup.sh e14d221
> test/system/continuous/start-stats.sh 5ece7f5
> test/system/randomwalk/bin/reset-cluster.sh 83dfcee
> test/system/randomwalk/bin/start-all.sh 67296de
> test/system/randomwalk/bin/start-local.sh c02b942
> test/system/scalability/run.py d0f9f51
>
> Diff: https://reviews.apache.org/r/15210/diff/
>
>
> Testing
> -------
>
> Functional Test (Auto): Executed successful run of Simple and Stress tests with and without ACCUMULO_CONF_DIR set.
>
> Continuous/Random Walk/Scalability - Executed simple tests to verify that ACCUMULO_CONF_DIR defaults to ACCUMULO_HOME/conf if missing.
>
>
> Thanks,
>
> Ryan Fishel
>
>