[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12215: fix delete authentication policies when delete topic.

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #12215:
URL: https://github.com/apache/pulsar/pull/12215#discussion_r717210724



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -632,25 +632,29 @@ protected void internalDeletePartitionedTopic(AsyncResponse asyncResponse, boole
                     return;
                 }
             }
+            // Only tries to delete the authentication policies for partitioned topic when all its partitions are
+            // successfully deleted
+            pulsar().getBrokerService().deleteTopicAuthenticationWithRetry(topicName.toString());

Review comment:
       Are we able to make an atomic update to ZooKeeper here? The semantics here are at-most-once, so failure would lead to corrupted zk state that will never be cleaned up.
   
   Note that with the current design, it is possible for this method to succeed while the `asyncResponse` completes without exception.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org