[GitHub] [accumulo] keith-turner commented on a change in pull request #1075: Revert thrift server to custom_hs_ha

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1075: Revert thrift server to custom_hs_ha
URL: https://github.com/apache/accumulo/pull/1075#discussion_r271881009
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java
 ##########
 @@ -607,18 +607,18 @@ public static ServerAddress startTServer(ThriftServerType serverType, TimedProce
             serverAddress = createBlockingServer(address, processor, protocolFactory,
                 maxMessageSize, serverName, numThreads, numSTThreads, timeBetweenThreadChecks);
             break;
-          case CUSTOM_HS_HA:
-            log.debug("Instantiating unsecure custom half-async Thrift server");
-            serverAddress = createNonBlockingServer(address, processor, protocolFactory, serverName,
-                numThreads, numSTThreads, timeBetweenThreadChecks, maxMessageSize);
-            break;
-          case THREADED_SELECTOR: // Intentional passthrough -- Our custom wrapper around threaded
-                                  // selector is the default
-          default:
+          case THREADED_SELECTOR:
             log.debug("Instantiating default, unsecure Threaded selector Thrift server");
             serverAddress = createThreadedSelectorServer(address, processor, protocolFactory,
                 serverName, numThreads, numSTThreads, timeBetweenThreadChecks, maxMessageSize);
             break;
+          case CUSTOM_HS_HA: // Intentional passthrough -- Our custom wrapper around threaded
+                             // selector is the default
+          default:
 
 Review comment:
   That's a subtle change to the behavior of an existing property, 2.0.0 seems like a good time to do something like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services