[jira] [Commented] (HBASE-4334) HRegion.get never validates row

["stack (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118668#comment-13118668 ] 

stack commented on HBASE-4334:
------------------------------

This bit looks strange to me Lars:

{code}
+    // start row can be empty in tests, so allow for that
+    byte[] startRow = scan.getStartRow();
+    if (startRow != null && !Bytes.equals(startRow, HConstants.EMPTY_START_ROW)) {
{code}

Its like tests get dispensation.  Should we fix the tests?

Otherwise patch looks good to me.
                
> HRegion.get never validates row
> -------------------------------
>
>                 Key: HBASE-4334
>                 URL: https://issues.apache.org/jira/browse/HBASE-4334
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.4
>            Reporter: Joe Pallas
>            Assignee: Lars Hofhansl
>             Fix For: 0.92.0
>
>         Attachments: 4334.txt
>
>
> If a client gets confused (possibly by a hole in .META., see HBASE-4333), it may send a request to the wrong region.  Paths through put, delete, incrementColumnValue, and checkAndMutate all call checkRow either directly or indirectly (through getLock).  But get apparently does not.  This can result in returning an incorrect empty result instead of a WrongRegionException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira