[jira] [Comment Edited] (HBASE-16288) HFile intermediate block level indexes might recurse forever creating multi TB files

["Heng Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397142#comment-15397142 ] 

Heng Chen edited comment on HBASE-16288 at 7/28/16 7:06 AM:
------------------------------------------------------------

{quote}
The index blocks go to the block cache still. So it might not be ideal to have a very large index block because the keys in there are large if we do only number-of-entries-based. 
{quote}

Yeah,  my point is the level of index should not depend on the size of first key.   If the index block has large key but a few sub entries,   it should still be one index block no matter how large the block size is. Configurable number is good. [~enis]


was (Author: chenheng):
{quote}
The index blocks go to the block cache still. So it might not be ideal to have a very large index block because the keys in there are large if we do only number-of-entries-based. 
{quote}

Yeah,  my point is the level of index should not depend on the size of first key.   If the index block has large key but a few sub entries,   it should still be one index block no matter how large the block size is. wdyt? [~enis]

> HFile intermediate block level indexes might recurse forever creating multi TB files
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-16288
>                 URL: https://issues.apache.org/jira/browse/HBASE-16288
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 1.2.3
>
>         Attachments: hbase-16288_v1.patch, hbase-16288_v2.patch, hbase-16288_v3.patch
>
>
> Mighty [~elserj] was debugging an opentsdb cluster where some region directory ended up having 5TB+ files under <regiondir>/.tmp/ 
> Further debugging and analysis, we were able to reproduce the problem locally where we never we recursing in this code path for writing intermediate level indices: 
> {code:title=HFileBlockIndex.java}
> if (curInlineChunk != null) {
>         while (rootChunk.getRootSize() > maxChunkSize) {
>           rootChunk = writeIntermediateLevel(out, rootChunk);
>           numLevels += 1;
>         }
>       }
> {code}
> The problem happens if we end up with a very large rowKey (larger than "hfile.index.block.max.size" being the first key in the block, then moving all the way to the root-level index building. We will keep writing and building the next level of intermediate level indices with a single very-large key. This can happen in flush / compaction / region recovery causing cluster inoperability due to ever-growing files. 
> Seems the issue was also reported earlier, with a temporary workaround: 
> https://github.com/OpenTSDB/opentsdb/issues/490



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)