You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/10/30 16:48:42 UTC

[kudu-CR] WIP: KUDU-1563 Use DELETE IGNORE in KuduRestore job 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16683


Change subject: WIP: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

WIP: KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE with kudu.setIgnoreAllNotFoundRows.

TODO: After KUDU-3211 automatically detect if DELETE_IGNORE is
supported and fall back to DELETE with
`kudu.setIgnoreAllNotFoundRows = true`.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16683/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 15:02:50 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16683

to look at the new patch set (#6).

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE when the cluster supports ignore
operations.

`session.setIgnoreAllNotFoundRows(true)` is retained to support
falling back to DELETE operations for backward compatibility.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 26 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16683/6
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 15:07:34 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 5: Verified+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:

http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@594
PS3, Line 594:   def testDeleteIgnore(): Unit = {
> nit: similar feedback to the previous patch -- might be nice to add a hint 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 07 Nov 2020 18:58:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16683

to look at the new patch set (#2).

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE when the cluster supports ignore
operations.

`session.setIgnoreAllNotFoundRows(true)` is retained to support
falling back to DELETE operations for backward compatibility.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
1 file changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16683/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:

http://gerrit.cloudera.org:8080/#/c/16683/3/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@594
PS3, Line 594:   @KuduTestHarness.MasterServerConfig(flags = Array("--master_support_ignore_operations=false"))
nit: similar feedback to the previous patch -- might be nice to add a hint for future readers that this test is intentionally identical to the below test.



-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Nov 2020 07:56:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16683

to look at the new patch set (#3).

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE when the cluster supports ignore
operations.

`session.setIgnoreAllNotFoundRows(true)` is retained to support
falling back to DELETE operations for backward compatibility.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 48 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16683/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16683

to look at the new patch set (#4).

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE when the cluster supports ignore
operations.

`session.setIgnoreAllNotFoundRows(true)` is retained to support
falling back to DELETE operations for backward compatibility.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 52 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16683/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 11:47:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................

KUDU-1563 Use DELETE_IGNORE in KuduRestore job

This patch changes the KuduRestore job to use DELETE_IGNORE
operations instead of DELETE when the cluster supports ignore
operations.

`session.setIgnoreAllNotFoundRows(true)` is retained to support
falling back to DELETE operations for backward compatibility.

Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Reviewed-on: http://gerrit.cloudera.org:8080/16683
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
2 files changed, 26 insertions(+), 4 deletions(-)

Approvals:
  Attila Bukor: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Grant Henke: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 14:42:30 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1563 Use DELETE IGNORE in KuduRestore job

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16683 )

Change subject: KUDU-1563 Use DELETE_IGNORE in KuduRestore job
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16683/5/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:

http://gerrit.cloudera.org:8080/#/c/16683/5/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@634
PS5, Line 634:   def testLegacyDeleteIgnore(): Unit = {
             :     insertRows(table, 100) // Insert data into the default test table.
             : 
             :     // Run and validate initial backup.
             :     backupAndValidateTable(tableName, 100, false)
             : 
             :     // Delete the rows and validate incremental backup.
             :     Range(0, 100).foreach(deleteRow)
             :     backupAndValidateTable(tableName, 100, true)
             : 
             :     // When restoring the table, delete half the rows after each job completes.
             :     // This will force delete rows to cause NotFound errors and allow validation
             :     // that they are correctly handled.
             :     val listener = new SparkListener {
             :       override def onJobEnd(jobEnd: SparkListenerJobEnd): Unit = {
             :         val client = kuduContext.syncClient
             :         val table = client.openTable(s"$tableName-restore")
             :         val scanner = kuduContext.syncClient.newScannerBuilder(table).build()
             :         val session = client.newSession()
             :         scanner.asScala.foreach { rr =>
             :           if (rr.getInt("key") % 2 == 0) {
             :             val delete = table.newDelete()
             :             val row = delete.getRow
             :             row.addInt("key", rr.getInt("key"))
             :             session.apply(delete)
             :           }
             :         }
             :       }
             :     }
             :     ss.sparkContext.addSparkListener(listener)
             : 
             :     restoreAndValidateTable(tableName, 0)
             :   }
Is it possible to separate this out into some sort of re-usable unit of code and use it here and in the above test,  having the same code but custom MasterServerConfig for the KuduTestHarness?



-- 
To view, visit http://gerrit.cloudera.org:8080/16683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f6d5a31be77630e79ff1566e796eb5183a5d22
Gerrit-Change-Number: 16683
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Nov 2020 07:49:38 +0000
Gerrit-HasComments: Yes