[GitHub] [incubator-superset] serenajiang opened a new pull request #8037: fix: handle case where result exists but corresponding query cannot be found

[GitBox <gi...@apache.org>]

serenajiang opened a new pull request #8037: fix: handle case where result exists but corresponding query cannot be found
URL: https://github.com/apache/incubator-superset/pull/8037
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Fixing [this bug](https://jira.airbnb.biz/browse/PRODUCT-93919).
   
   In some cases, a result existed in the results backend but a query with the corresponding `results_key` did not exist in the queries table. This used to throw a 500 because `one()` expected a query with that `results_key` to exist.
   
   Now, it will return a generic error if no query exists. 
   
   As a possible future fix for this error, we could use the information in the query object within the `blob` instead of looking up the corresponding query.
   
   ### TEST PLAN
   Tested on devbox. Confirmed that this link now returns the desired error instead of 500:
   ```superset/results/3e5cf196-ea99-4891-a5c4-5ed00eb3bf25/```
   
   ### REVIEWERS
   @etr2460 @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org