You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/07/15 16:23:06 UTC
[GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/747
Don't use hostname when obtaining machines
By default Softlayer machines will have a hostname of the form `xxxx.local.brooklyncentral.com` which resolves to a parked domain, not the public IP of the machine. When the machine has privte IP only the hostname was used instead of the private IP which caused a failure. This commit removes the hostname fallback - I don't see a valid reason why it should be included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/ip-only-obtain
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #747
----
commit b2ec359cf1e959d5831237ae59c88a7175c99d98
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-07-15T14:22:04Z
Don't use hostname when obtaining machines
By default Softlayer machines will have a hostname of the form xxxx.local.brooklyncentral.com which resolves to a parked domain, not the public IP of the machine. When the machine has privte IP only the hostname was used instead of the private IP which caused a failure. This commit removes the hostname fallback - I don't see a valid reason why it should be included.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/747#issuecomment-121774055
Looks good. Happy to merge once asfbot confirms build works.
The previous attempt failed. Can you close/reopen (or equivalent) to kick off the asfbot again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/747#issuecomment-121897731
New build is successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/747
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/747#issuecomment-122036007
In addition to ASF bot reporting a successful build, I fetched, built, ran all tests successfully. I confirm that this PR can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---