[BUILD FAIL] awsapi packaging type changed to war

[Rohit Yadav <ro...@citrix.com>]

Hi Hugo,

Need you help on this one; some recent patches have cause some build issues on master. All jobs on jenkins for the master branch are failing.

The packaging type on awsapi/pom.xml is now war, so when we do mvn -P deps we get the following as it tries to search jar, but it's a war package now:

[ERROR] Failed to execute goal on project cloud-deps: Could not resolve dependencies for project org.apache.cloudstack:cloud-deps:jar:4.1.0-SNAPSHOT: Could not find artifact org.apache.cloudstack:cloud-awsapi:jar:4.1.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]

I fixed this by declaring awsapi as war type in deps/pom.xml:

diff --git a/deps/pom.xml b/deps/pom.xml
index 38bb171..182028d 100644
--- a/deps/pom.xml
+++ b/deps/pom.xml
@@ -101,6 +101,7 @@
       <groupId>org.apache.cloudstack</groupId>
       <artifactId>cloud-awsapi</artifactId>
       <version>${project.version}</version>
+      <type>war</type>
     </dependency>
     <dependency>

But, now it fails on ant build-all as it copies old versions into deps/ which I'm unable to debug as to why it does that.

Another hack which worked for me was to copy the war pkg to jar in ~/.m2;
cp cloud-awsapi-4.1.0-SNAPSHOT.war cloud-awsapi-4.1.0-SNAPSHOT.jar 

After this, it worked fine, both mvn -P deps and ant build-all succeeded.

I've posted a patch related to this issue. This fixes some rampart version issues and ant build complains:
https://reviews.apache.org/r/7406/

Regards.