You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Vlad Rozov (JIRA)" <ji...@apache.org> on 2012/08/31 06:03:09 UTC
[jira] [Created] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Vlad Rozov created HADOOP-8751:
----------------------------------
Summary: NPE in Token.toString() when Token is constructed using null identifier
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: Vlad Rozov
Priority: Minor
Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445691#comment-13445691 ]
Hadoop QA commented on HADOOP-8751:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//console
This message is automatically generated.
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Vlad Rozov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445696#comment-13445696 ]
Vlad Rozov commented on HADOOP-8751:
------------------------------------
Failure in TestZKFailoverController is caused HADOOP-8591.
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Vlad Rozov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446420#comment-13446420 ]
Vlad Rozov commented on HADOOP-8751:
------------------------------------
I don't think it is important to distinguish between null and empty fields in the Token class. Default constructor initializes to empty fields. For consistency and to avoid checks for nullness, IMHO it is easier to prevent fields to be null altogether.
In the TestHftpDelegationToken test case both null and empty byte arrays are used to initialize identifier and password.
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Vlad Rozov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vlad Rozov updated HADOOP-8751:
-------------------------------
Attachment: HADOOP-8751.patch
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446349#comment-13446349 ]
Daryn Sharp commented on HADOOP-8751:
-------------------------------------
I'm not sure that we should prevent nulls for the various fields. Although I'm fine with handling a null identifier even though that's really an invalid use case.
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8751) NPE in Token.toString() when Token
is constructed using null identifier
Posted by "Vlad Rozov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vlad Rozov updated HADOOP-8751:
-------------------------------
Fix Version/s: 2.0.0-alpha
Status: Patch Available (was: Open)
> NPE in Token.toString() when Token is constructed using null identifier
> -----------------------------------------------------------------------
>
> Key: HADOOP-8751
> URL: https://issues.apache.org/jira/browse/HADOOP-8751
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.0.0-alpha
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 2.0.0-alpha
>
> Attachments: HADOOP-8751.patch
>
>
> Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira