You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/27 20:47:30 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in

thisisnic commented on a change in pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#discussion_r640955015



##########
File path: r/R/compute.R
##########
@@ -241,13 +241,11 @@ all.ArrowDatum <- function(..., na.rm = FALSE){
 #' `boolean`-type `Array` of the same length as `x` with values indicating
 #' per element of `x` it it is present in `table`.
 #' @export
-match_arrow <- function(x, table, ...) UseMethod("match_arrow")
-
-#' @export
-match_arrow.default <- function(x, table, ...) match(x, table, ...)

Review comment:
       @jonkeane That makes sense, it is a breaking change after all.  Just committed an update - let me know if I should rephrase it.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org