You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2009/03/28 21:50:45 UTC
Re: svn commit: r36827 - trunk/subversion/libsvn_fs_fs
On Sat, Mar 28, 2009 at 02:05:52PM -0700, Bert Huijben wrote:
> Author: rhuijben
> Date: Sat Mar 28 14:05:52 2009
> New Revision: 36827
>
> Log:
> * subversion/libsvn_fs_fs/fs_fs.c
> (write_config): Fix typo in default config.
>
> Found by: Sander Rijken <sa...@open.collab.net>
>
> Modified:
> trunk/subversion/libsvn_fs_fs/fs_fs.c
>
> Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?pathrev=36827&r1=36826&r2=36827
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 12:54:04 2009 (r36826)
> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 14:05:52 2009 (r36827)
> @@ -1089,7 +1089,7 @@ write_config(svn_fs_t *fs,
> "" NL
> "[" CONFIG_SECTION_REP_SHARING "]" NL
> "### To conserve space, the filesystem can optionally avoid storing" NL
> -"### duplicate representations. This comes at a slight cost in performace," NL
> +"### duplicate representations. This comes at a slight cost in performance," NL
> "### as maintaining a database of shared representations can increase" NL
Those double spaces aren't typos. They are all over our tree.
It's a lightweight alternative to starting a new paragraph.
I'd say we should just leave them as-is, because we'll have to
change too many places if we wanted to eradicate them all.
Note that there are two spaces between the sentence you changed
and the one that follows it, too :)
> "### commit times. The space savings are dependent upon the size of the" NL
Stefan
> "### repository, the number of objects it contains and the amount of" NL
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1461154
Re: svn commit: r36827 - trunk/subversion/libsvn_fs_fs
Posted by Stefan Sperling <st...@elego.de>.
On Sat, Mar 28, 2009 at 10:56:42PM +0100, Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-03-28 22:50:45 Stefan Sperling napisa??(a):
> > On Sat, Mar 28, 2009 at 02:05:52PM -0700, Bert Huijben wrote:
> > > Author: rhuijben
> > > Date: Sat Mar 28 14:05:52 2009
> > > New Revision: 36827
> > >
> > > Log:
> > > * subversion/libsvn_fs_fs/fs_fs.c
> > > (write_config): Fix typo in default config.
> > >
> > > Found by: Sander Rijken <sa...@open.collab.net>
> > >
> > > Modified:
> > > trunk/subversion/libsvn_fs_fs/fs_fs.c
> > >
> > > Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
> > > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?pathrev=36827&r1=36826&r2=36827
> > > ==============================================================================
> > > --- trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 12:54:04 2009 (r36826)
> > > +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 14:05:52 2009 (r36827)
> > > @@ -1089,7 +1089,7 @@ write_config(svn_fs_t *fs,
> > > "" NL
> > > "[" CONFIG_SECTION_REP_SHARING "]" NL
> > > "### To conserve space, the filesystem can optionally avoid storing" NL
> > > -"### duplicate representations. This comes at a slight cost in performace," NL
> > > +"### duplicate representations. This comes at a slight cost in performance," NL
> > > "### as maintaining a database of shared representations can increase" NL
> >
> > Those double spaces aren't typos.
>
> See s/performace/performance/ at the end of that line :) .
Ah :)
Sorry,
Stefan
Re: svn commit: r36827 - trunk/subversion/libsvn_fs_fs
Posted by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com>.
2009-03-28 22:50:45 Stefan Sperling napisał(a):
> On Sat, Mar 28, 2009 at 02:05:52PM -0700, Bert Huijben wrote:
> > Author: rhuijben
> > Date: Sat Mar 28 14:05:52 2009
> > New Revision: 36827
> >
> > Log:
> > * subversion/libsvn_fs_fs/fs_fs.c
> > (write_config): Fix typo in default config.
> >
> > Found by: Sander Rijken <sa...@open.collab.net>
> >
> > Modified:
> > trunk/subversion/libsvn_fs_fs/fs_fs.c
> >
> > Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?pathrev=36827&r1=36826&r2=36827
> > ==============================================================================
> > --- trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 12:54:04 2009 (r36826)
> > +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Mar 28 14:05:52 2009 (r36827)
> > @@ -1089,7 +1089,7 @@ write_config(svn_fs_t *fs,
> > "" NL
> > "[" CONFIG_SECTION_REP_SHARING "]" NL
> > "### To conserve space, the filesystem can optionally avoid storing" NL
> > -"### duplicate representations. This comes at a slight cost in performace," NL
> > +"### duplicate representations. This comes at a slight cost in performance," NL
> > "### as maintaining a database of shared representations can increase" NL
>
> Those double spaces aren't typos.
See s/performace/performance/ at the end of that line :) .
> They are all over our tree.
> It's a lightweight alternative to starting a new paragraph.
>
> I'd say we should just leave them as-is, because we'll have to
> change too many places if we wanted to eradicate them all.
>
> Note that there are two spaces between the sentence you changed
> and the one that follows it, too :)
>
> > "### commit times. The space savings are dependent upon the size of the" NL
>
> Stefan
>
> > "### repository, the number of objects it contains and the amount of" NL
--
Arfrever Frehtes Taifersar Arahesis