You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ahuang98 (via GitHub)" <gi...@apache.org> on 2023/07/27 17:53:14 UTC

[GitHub] [kafka] ahuang98 commented on a diff in pull request #14084: [MINOR] Add latest versions to kraft upgrade kafkatest

ahuang98 commented on code in PR #14084:
URL: https://github.com/apache/kafka/pull/14084#discussion_r1276628397


##########
tests/kafkatest/version.py:
##########
@@ -252,3 +252,7 @@ def get_version(node=None):
 V_3_5_0 = KafkaVersion("3.5.0")
 V_3_5_1 = KafkaVersion("3.5.1")
 LATEST_3_5 = V_3_5_1
+
+# 3.6.x versions
+V_3_6_0 = KafkaVersion("3.6.0")
+LATEST_3_6 = V_3_6_0

Review Comment:
   I had noticed that 3.6 had been removed when I was working on this change and just thought I'd add it back in this PR since it seemed the convention was to add the new version whenever we created a release branch for the prior version. Other than some OCD to follow the existing pattern, I'm indifferent to keeping it or leaving it out since as you said, it's not in use currently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org