[GitHub] [bookkeeper] lhotari commented on a diff in pull request #3528: Fix memory leak when reading entry but the connection disconnected.

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #3528:
URL: https://github.com/apache/bookkeeper/pull/3528#discussion_r1082407767


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -119,12 +121,17 @@ protected void sendResponse(int rc, Object response, OpStatsLogger statsLogger)
         }
 
         if (channel.isActive()) {
-            channel.writeAndFlush(response, channel.voidPromise());
+            ChannelPromise promise = channel.newPromise().addListener(future -> {
+                if (!future.isSuccess()) {
+                    logger.debug("Netty channel write exception. ", future.cause());
+                }
+            });

Review Comment:
   This will cause unnecessary object creation. If the only purpose is to log exceptions, `channel.voidPromise()` already takes care of that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org