You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/03 11:00:08 UTC

[GitHub] [dubbo-go] Lvnszn opened a new pull request #1772: feat: change lint to official lint

Lvnszn opened a new pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**: 
   切换到官方的 lint，可跳过 unused 的校验
   **Which issue(s) this PR fixes**: 
   Fixes #
   
   **You should pay attention to items below to ensure your pr passes our ci test**
   We do not merge pr with ci tests failed
   
   - [ ] All ut passed (run 'go test ./...' in project root)
   - [ ] After go-fmt ed , run 'go fmt project' using goland.
   - [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
   - [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above) 
   - [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
   - [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d914d62) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.17%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head d914d62 differs from pull request most recent head 55d8132. Consider uploading reports for the commit 55d8132 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.36%   +0.17%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7080      +39     
   + Misses       7111     7093      -18     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <0.00%> (-1.72%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `44.82% <0.00%> (+3.44%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...55d8132](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d914d62) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.17%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head d914d62 differs from pull request most recent head 3dbc8c5. Consider uploading reports for the commit 3dbc8c5 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.36%   +0.17%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7080      +39     
   + Misses       7111     7093      -18     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <0.00%> (-1.72%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `44.82% <0.00%> (+3.44%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...3dbc8c5](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

AlexStocks merged pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d914d62) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.17%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head d914d62 differs from pull request most recent head bf7ee57. Consider uploading reports for the commit bf7ee57 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.36%   +0.17%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7080      +39     
   + Misses       7111     7093      -18     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <0.00%> (-1.72%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `44.82% <0.00%> (+3.44%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...bf7ee57](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24cece0) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.18%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head 24cece0 differs from pull request most recent head bf7ee57. Consider uploading reports for the commit bf7ee57 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.37%   +0.18%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7081      +40     
   + Misses       7111     7092      -19     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [config/ssl\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NzbF9jb25maWcuZ28=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...bf7ee57](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24cece0) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.18%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head 24cece0 differs from pull request most recent head c408f92. Consider uploading reports for the commit c408f92 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.37%   +0.18%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7081      +40     
   + Misses       7111     7092      -19     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [config/ssl\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NzbF9jb25maWcuZ28=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...c408f92](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Lvnszn commented on a change in pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

Lvnszn commented on a change in pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#discussion_r819308972



##########
File path: .github/workflows/golangci-lint.yml
##########
@@ -0,0 +1,23 @@
+name: golangci-lint
+on:
+  push:
+    branches: [master, develop, "1.5", "3.0"]
+  pull_request:
+    branches: "*"
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.15
+          id: go

Review comment:
       addressed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

zhaoyunxing92 commented on a change in pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#discussion_r819301674



##########
File path: .github/workflows/golangci-lint.yml
##########
@@ -0,0 +1,23 @@
+name: golangci-lint
+on:
+  push:
+    branches: [master, develop, "1.5", "3.0"]
+  pull_request:
+    branches: "*"
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v2
+        with:
+          go-version: 1.15
+          id: go

Review comment:
       应该移除`id`这个标签




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24cece0) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.18%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head 24cece0 differs from pull request most recent head 201722a. Consider uploading reports for the commit 201722a to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.37%   +0.18%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7081      +40     
   + Misses       7111     7092      -19     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [config/ssl\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NzbF9jb25maWcuZ28=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...201722a](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1772: feat: change lint to official lint

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1772:
URL: https://github.com/apache/dubbo-go/pull/1772#issuecomment-1057938629


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1772](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24cece0) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/85b55bfc0e7082e81a1c898011bad60dcdc93150?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85b55bf) will **increase** coverage by `0.18%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head 24cece0 differs from pull request most recent head 496f2a2. Consider uploading reports for the commit 496f2a2 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1772/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1772      +/-   ##
   ==========================================
   + Coverage   47.18%   47.37%   +0.18%     
   ==========================================
     Files         257      259       +2     
     Lines       14921    14947      +26     
   ==========================================
   + Hits         7041     7081      +40     
   + Misses       7111     7092      -19     
   - Partials      769      774       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/uniform\_router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3VuaWZvcm1fcm91dGVyX2NvbmZpZy5nbw==) | `57.69% <ø> (+57.69%)` | :arrow_up: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [config/config\_utils.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ191dGlscy5nbw==) | `100.00% <100.00%> (ø)` | |
   | [config/parsers/properties/properties.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3BhcnNlcnMvcHJvcGVydGllcy9wcm9wZXJ0aWVzLmdv) | `43.33% <100.00%> (ø)` | |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [config/generic/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWMvZ2VuZXJpY19zZXJ2aWNlLmdv) | `100.00% <0.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80.86% <0.00%> (+2.60%)` | :arrow_up: |
   | [config/ssl\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1772/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NzbF9jb25maWcuZ28=) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed8aa47...496f2a2](https://codecov.io/gh/apache/dubbo-go/pull/1772?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org