You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by drazzib <gi...@git.apache.org> on 2015/02/09 23:43:24 UTC
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
GitHub user drazzib opened a pull request:
https://github.com/apache/gora/pull/19
Gradle plugin for Apache Gora (GORA-330)
I've finally took some time to offer a clean PR to merge my Gradle plugin (see GORA-330 for details).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Dictanova/gora GORA-330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit fd0372b64ee0e945c6214fdb88d52b247a70651f
Author: Damien Raude-Morvan <dr...@drazzib.com>
Date: 2015-02-09T22:37:39Z
Start import of Gradle plugin into Apache Gora Git
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/gora/pull/19#issuecomment-73607415
Hi @drazzib, could you create JIRA account for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/19#issuecomment-73893685
Hi @drazzib
RE: license headers, great
RE: Gora Schema files, yes you are correct this is absolutely fine
+1 for commit to master branch. If you are keen and able, please feel free to set up an additional build job on builds.apache.org if you have tests for the plugin which you would like to run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/gora/pull/19#issuecomment-73607576
Ah I was an idiot =P
Never mind =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: Gradle plugin for Apache Gora (GORA-330)
Posted by drazzib <gi...@git.apache.org>.
Github user drazzib commented on the pull request:
https://github.com/apache/gora/pull/19#issuecomment-73860723
Hi @lewismc
I've pushed ASL 2.0 headers on some more files but haven't proceed all :
- gradlew + gradlew.bat + gradle/wrapper/* are auto-generated from Gradle build system
- examples/simple/src/main/resources/test1.avsc It seems we can't add comment into Gora Schema files ? Am I wrong ?
I'm okay for pushing this to master now but it should be noted that it's still WiP (for instance, there is no real configuration for source / destination directories)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---