You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/07/17 21:55:57 UTC
Review Request 36574: Added helper testing functions for Labels.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
Bugs: MESOS-3076
https://issues.apache.org/jira/browse/MESOS-3076
Repository: mesos
Description
-------
- addLabel(lables, key, val) inserts a Label (key,val) into labels.
- labelJSON(key, val) returns a JSON value with key-val pair.
Diffs
-----
src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 36574: Added helper testing functions for Labels.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/#review92189
-----------------------------------------------------------
src/tests/mesos.hpp (line 1382)
<https://reviews.apache.org/r/36574/#comment146214>
Can we make this functional instead? s/addLabel/createLabel/ and return the created Label. Then later we can do:
labels->add_labels()->CopyFrom(createLabel("foo", "bar"));
src/tests/slave_tests.cpp (line 2077)
<https://reviews.apache.org/r/36574/#comment146213>
labels->add_labels()->CopyFrom(createLabel("foo", "bar"));
src/tests/slave_tests.cpp (line 2126)
<https://reviews.apache.org/r/36574/#comment146215>
Once we have a 'createLabel' we can just do `JSON::Protobuf(createLabel("foo", "bar"))` here.
- Benjamin Hindman
On July 17, 2015, 7:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36574/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 7:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-3076
> https://issues.apache.org/jira/browse/MESOS-3076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - addLabel(lables, key, val) inserts a Label (key,val) into labels.
> - labelJSON(key, val) returns a JSON value with key-val pair.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
> src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
> src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
>
> Diff: https://reviews.apache.org/r/36574/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 36574: Added a helper testing functions for Labels.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/#review92463
-----------------------------------------------------------
Ship it!
src/tests/mesos.hpp (line 1382)
<https://reviews.apache.org/r/36574/#comment146658>
We should really move this to src/common/protobuf_utils.cpp.
- Benjamin Hindman
On July 21, 2015, 4:45 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36574/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 4:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-3076
> https://issues.apache.org/jira/browse/MESOS-3076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> * createLabel(key, value) return a new "key":"value" Label.
>
>
> Diffs
> -----
>
> src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
> src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
> src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
> src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
>
> Diff: https://reviews.apache.org/r/36574/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 36574: Added a helper testing functions for Labels.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/
-----------------------------------------------------------
(Updated July 21, 2015, 12:45 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
Bugs: MESOS-3076
https://issues.apache.org/jira/browse/MESOS-3076
Repository: mesos
Description
-------
* createLabel(key, value) return a new "key":"value" Label.
Diffs
-----
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 36574: Added a helper testing functions for Labels.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/
-----------------------------------------------------------
(Updated July 21, 2015, 12:45 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
Changes
-------
addressed BenH's comments.
Summary (updated)
-----------------
Added a helper testing functions for Labels.
Bugs: MESOS-3076
https://issues.apache.org/jira/browse/MESOS-3076
Repository: mesos
Description (updated)
-------
* createLabel(key, value) return a new "key":"value" Label.
Diffs (updated)
-----
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 36574: Added helper testing functions for Labels.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36574/
-----------------------------------------------------------
(Updated July 18, 2015, 8:38 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
Changes
-------
Rebased and addressed BenH's comments.
Bugs: MESOS-3076
https://issues.apache.org/jira/browse/MESOS-3076
Repository: mesos
Description
-------
- addLabel(lables, key, val) inserts a Label (key,val) into labels.
- labelJSON(key, val) returns a JSON value with key-val pair.
Diffs (updated)
-----
src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
-------
make check
Thanks,
Kapil Arya