You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/04 17:58:00 UTC
[GitHub] [tvm] kparzysz-quic opened a new pull request #7973: [Relay] Return the proper module from _build_module_no_factory
kparzysz-quic opened a new pull request #7973:
URL: https://github.com/apache/tvm/pull/7973
The `module` member is the factory itself. The module to be executed is returned by `get_lib` (which also happens to be imported into the factory module, i.e. `module.imported_modules[0] == get_lib()`).
Pinging @jroesch since he wrote that code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic closed pull request #7973: [Relay] Return the proper module from _build_module_no_factory
Posted by GitBox <gi...@apache.org>.
kparzysz-quic closed pull request #7973:
URL: https://github.com/apache/tvm/pull/7973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #7973: [Relay] Return the proper module from _build_module_no_factory
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7973:
URL: https://github.com/apache/tvm/pull/7973#discussion_r630990178
##########
File path: python/tvm/relay/build_module.py
##########
@@ -216,7 +216,7 @@ def _build_module_no_factory(mod, target=None, target_host=None, params=None, mo
the runtime::Module can be freely passed between language boundaries.
"""
target, target_host = Target.check_and_update_host_consist(target, target_host)
- return build(mod, target, params=params, mod_name=mod_name).module
+ return build(mod, target, params=params, mod_name=mod_name).get_lib()
Review comment:
After reading the registered code, I believe this is the right callback in relay build. perhaps @jroesch can confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org