You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2022/08/01 02:06:44 UTC

[GitHub] [incubator-nemo] jeongyooneo commented on a diff in pull request #323: [MINOR] Bump Library Versions

jeongyooneo commented on code in PR #323:
URL: https://github.com/apache/incubator-nemo/pull/323#discussion_r934085489


##########
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java:
##########
@@ -281,8 +281,7 @@ public TimerInternals timerInternals() {
     final DoFn wrappedDoFn = wrapDoFn(doFn);
 
     // invoker
-    doFnInvoker = DoFnInvokers.invokerFor(wrappedDoFn);
-    doFnInvoker.invokeSetup();
+    doFnInvoker = DoFnInvokers.tryInvokeSetupFor(wrappedDoFn); // options?

Review Comment:
   How about adding an exception handling statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org