[jira] [Commented] (THRIFT-3750) NSCopying copyWithZone: implementation does not check isSet

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334598#comment-15334598 ] 

ASF GitHub Bot commented on THRIFT-3750:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/958


> NSCopying copyWithZone: implementation does not check isSet
> -----------------------------------------------------------
>
>                 Key: THRIFT-3750
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3750
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>    Affects Versions: 1.0
>            Reporter: Zach Howe
>             Fix For: 1.0
>
>
> The NSCopying copyWithZone: implementation does not check isSet. This causes the copy not to be a true copy, since all the isSet properties will be set to YES on the newly copied object.
> Note, updating to provide some more clarity:
> In this example, it's fixed:
> {code}
> - (instancetype) copyWithZone:(NSZone *)zone
> {
>   Foo * val = [Foo new];
>   if (_nameIsSet)
>   {
>     val.name = [self.name copy];
>   }
>   return val;
> }
> {code}
> Without the if check on _nameIsSet, the newly copied object will have _nameIsSet set to YES but with a nil name.
> {code}
> - (void) setName: (NSString *) name {
>   _name = name;
>   _nameIsSet = YES;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)