[jira] [Commented] (VCL-664) hard coded references to "Local Account"

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171886#comment-14171886 ] 

ASF subversion and git services commented on VCL-664:
-----------------------------------------------------

Commit 1631933 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1631933 ]

VCL-664 - hard coded references to "Local Account"

authentication.php:
-modified submitLogin: added $authtype parameter for call to localLogin
-modified localLogin: added $authtype argument; changed addLoginLog calls to use passed in $authtype for 2nd parameter instead of 'Local' and to use it to get the right affiliationid from the $authMechs array instead of hard coding 'Local Account'; use $authtype as parameter for calling printLoginPageWithSkin instead of hard coding 'Local Account'

> hard coded references to "Local Account"
> ----------------------------------------
>
>                 Key: VCL-664
>                 URL: https://issues.apache.org/jira/browse/VCL-664
>             Project: VCL
>          Issue Type: Bug
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>             Fix For: 2.4
>
>
> authentication.php (others?) have hard coded references to "Local Account" for the $authMechs array. People may want to name a local authentication option something other than "Local Account". If they try renaming it, an error is generated and people cannot log in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)